-
-
Notifications
You must be signed in to change notification settings - Fork 85
fix license values in pyproject.toml #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+5
−4
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to move out of the 3.2.4 section now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wshanks where should it go, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.2.4is released. We need a new unreleased section and it will eventually go into, probably,3.2.5. Or if this is the only change we want in3.2.5you can make a3.2.5section put it in there and we can release again today or tomorrow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally baffled. Did someone push 3.2.4 to PyPI? I did not.
The changes to
pyproject.tomlshould be made at some point.Closing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion. When I asked this:
I meant "should we try triggering the 3.2.4 publish workflow resulting in 3.2.4 being successfully published?" So that was what I tried and it did result in the previously identified commit (current
master) being published as 3.2.4.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just re-open this PR to keep the issue tracked so we don't forget about it? Totally independent of 4.0 timeline, just don't want to lose track of it since you've already done work for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this didn't get put into 3.2.4. But I will leave that up to you and @wshanks.... still a bit miffed that I started working on this untagged 3.2.4, and then3.2.4 got released despite working to fix this and waiting for comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I thought my message here was pretty clear that I was asking about trying to release 3.2.4 without the changes in this PR because they were not necessary for the release of 3.2.4 that we had already agreed on releasing (GitHub releases are tied to git tags).
Over the last year, my use of Uncertainties has been very minimal, so my efforts here are just recreational because I find it fun to maintain code that other people find useful. The amount of activity on this repo that evokes a negative emotion in me too high for a recreational project. There are enough other maintainers and you are more than capable of keeping this project in good shape. I am going to withdraw from maintainership at this time.