fix: handle NaN colors in plotly create_tile - #266
Merged
Conversation
- add default_color param to create_tile, fallback when element[color] is NaN/None - pass missing→default_color from periodic_table_plotly to create_tile - remove nbsphinx_allow_errors workaround from conf.py - add TestCreateTile with 5 tests (valid, NaN, custom default, None, bounds)
- rewrite create_tile tests as plain functions (no class) - AGENTS.md: add pytest-style convention note - CONTRIBUTING.md: add Writing Tests section with examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249
create_tile(): adddefault_colorparam, fallback when element color is NaN/Noneperiodic_table_plotly(): passmissingthrough asdefault_colortocreate_tile()nbsphinx_allow_errors = Trueworkaround from conf.pycreate_tile(valid color, NaN default, NaN custom, None, bounds)