Skip to content

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Oct 2, 2025

Important

Introduces merge_text_parts for handling text merging in streaming responses and updates related functions and tests.

  • Behavior:
    • Introduces merge_text_parts function in utils.py to merge text parts in streaming responses.
    • Updates _build_from_streaming_response and _abuild_from_streaming_response in __init__.py to use merge_text_parts.
  • Testing:
    • Adds test_google_genai_streaming in test_google_genai.py to test streaming response handling.
    • Adds multiple tests for merge_text_parts in test_utils.py to cover various input scenarios.
  • Misc:
    • Bumps version to 0.7.17 in pyproject.toml and version.py.
    • Adds opentelemetry-instrumentation-threading to dependencies in pyproject.toml.

This description was created by Ellipsis for afd8ab2. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to afd8ab2 in 1 minute and 51 seconds. Click for details.
  • Reviewed 556 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. pyproject.toml:8
  • Draft comment:
    Version bump to 0.7.17 and addition of opentelemetry-instrumentation-threading dependency looks good.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that the version bump and dependency addition look good, which is not useful for the PR author.
2. src/lmnr/opentelemetry_lib/opentelemetry/instrumentation/google_genai/__init__.py:404
  • Draft comment:
    Using merge_text_parts(final_parts) in streaming response builders ensures text parts are properly concatenated.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply states what a function does without questioning its use or suggesting alternatives.
3. src/lmnr/version.py:6
  • Draft comment:
    Version update in version.py is consistent with pyproject.toml.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, stating that the version update is consistent between two files. It doesn't provide any actionable feedback or suggestions for improvement.
4. tests/test_google_genai.py:850
  • Draft comment:
    Streaming test verifies that text parts are merged correctly. The expected multi‐line poem output is comprehensive.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, describing what the streaming test does and the expected output. It doesn't provide any actionable feedback or suggestions for improvement.
5. tests/test_utils.py:812
  • Draft comment:
    Merge_text_parts tests are comprehensive, covering string inputs, Part objects, dict inputs, mixed types, non-text parts, and file objects.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, describing the coverage of tests for the merge_text_parts function. It does not provide any actionable feedback or suggestions for improvement.

Workflow ID: wflow_KVudBev2X3pt2K8b

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@olzhik11
Copy link
Member

olzhik11 commented Oct 2, 2025

bugbot run

Copy link

cursor bot commented Oct 2, 2025

Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository.

@olzhik11 olzhik11 merged commit 2c1427d into main Oct 2, 2025
7 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants