Tests for non-priviledged commands #283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CLA signed
will-lms
reviewed
Sep 2, 2025
Contributor
will-lms
left a comment
will-lms
left a comment
There was a problem hiding this comment.
CI is failing
Error: A branch or tag with the name 'rugved/lm' could not be found
Is something about the regex match not working?
Member
Author
Fixed |
will-lms
reviewed
Sep 9, 2025
Comment on lines
+103
to
+113
| # mkdir -p /.lmstudio/hub/models/google | ||
| # cd /.lmstudio/hub/models/google | ||
| # lms clone google/gemma-3-1b | ||
| # mkdir -p /.lmstudio/models/lmstudio-community/gemma-3-1b-it-GGUF | ||
| # cd /.lmstudio/models/lmstudio-community/gemma-3-1b-it-GGUF | ||
| # if ! command -v wget &> /dev/null; then | ||
| # apt-get update | ||
| # apt-get install -y wget | ||
| # fi | ||
| # wget --quiet -P /tmp https://models.lmstudio.ai/models/gemma-3-1b-it-Q4_K_M.gguf && mv /tmp/gemma-3-1b-it-Q4_K_M.gguf gemma-3-1b-it-Q4_K_M.gguf | ||
|
|
| const cliPath = path.join(__dirname, TEST_CLI_PATH); | ||
|
|
||
| describe("version command", () => { | ||
| it("should display version with ASCII art", () => { |
Contributor
There was a problem hiding this comment.
I still find this test name to be misleading, as it is not actually testing for the existence of ASCII art.
Also it does not check the key part of the output -- the version. It should make sure the version is present in the output, or at least some v\d+\.\d+\.\d+ check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This brings the first batch of tests which are for non-privileged features and for the commands which don't require some changes to make them 'test-friendly' (example is
createcommand which does not have a one liner approach to run yet)This PR includes tests for:
Rest of the subcommands tests will be made in separate PRs.
Below is a new format of specifying branch for a specific submodule, as example in this branch the tests would be run on
rugved/lms-cli-testsbranch oflmstudio.jsbecause that has the logic of runninglms-clitests and the current branch oflms-clilmstudio-js-branch:rugved/lms-cli-tests