Skip to content

add 27.1, 27.2 and 28.0, use alpine:3.20 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AaronDewes merged 6 commits into from
Jan 17, 2025
Merged

add 27.1, 27.2 and 28.0, use alpine:3.20 #105

AaronDewes merged 6 commits into from
Jan 17, 2025

Conversation

@lnliz
Copy link
Contributor

@lnliz lnliz commented Oct 19, 2024

No description provided.

@lnliz lnliz changed the title add 27.1 and 28.0, upgrade actions/checkout to v4 add 27.1 and 28.0, use alpine:3.20, use actions/checkout@v4 Oct 19, 2024
AaronDewes
AaronDewes reviewed Oct 19, 2024
View reviewed changes
@lnliz lnliz mentioned this pull request Oct 19, 2024
Closed
@lnliz
Copy link
Contributor Author

lnliz commented Oct 21, 2024

https://github.com/lncm/docker-bitcoind/actions/runs/11423159532/job/31782577207
error: 260.5 gpg: keydb_search failed: Operation timed out

@nolim1t - can you retry the failed github action please?

and should I reduce the number of versions that are run? i can remove 24.x and 25.x from the tests?

@nolim1t
Copy link
Member

nolim1t commented Oct 22, 2024

I'm ok with removing 24 and 25

@lnliz
Copy link
Contributor Author

lnliz commented Oct 22, 2024

I'm ok with removing 24 and 25

thanks, done

@lnliz
Copy link
Contributor Author

lnliz commented Oct 31, 2024

@nolim1t - quick bump, this is RFR/RFM

@nolim1t
Copy link
Member

nolim1t commented Nov 5, 2024

ok adding it in soon.

Sorry about the slow service

@lnliz
Copy link
Contributor Author

lnliz commented Nov 15, 2024

No problem. Let me know if there is anything I can do to help.

@donnlee
Copy link

donnlee commented Dec 12, 2024

To build this 28.0 Dockerfile I had to make the following changes:
Remove line RUN echo "Not implemented" && exit 1

Modify this line:

-RUN gpg --keyserver keyserver.ubuntu.com --recv-keys $KEYS
+RUN gpg --keyserver keyserver.ubuntu.com --recv-keys $KEYS && gpgconf --kill all

@lnliz
Copy link
Contributor Author

lnliz commented Jan 13, 2025 •
edited
Loading

@nolim1t - I also added bitcoin 28.1

nevermind - not including 28.1 here as the build is not working yet.

@lnliz lnliz changed the title add 27.1 and 28.0, use alpine:3.20, use actions/checkout@v4 add 27.1 and 28.0/28.1, use alpine:3.20, use actions/checkout@v4 Jan 14, 2025
@lnliz lnliz changed the title add 27.1 and 28.0/28.1, use alpine:3.20, use actions/checkout@v4 add 27.1 and 28.0, use alpine:3.20, use actions/checkout@v4 Jan 14, 2025
@AaronDewes
Copy link
Contributor

AaronDewes commented Jan 17, 2025

If CI passes on this, I'll merge it and we can deal with 28.1 later.

Thank you for creating this!

@AaronDewes AaronDewes changed the title add 27.1 and 28.0, use alpine:3.20, use actions/checkout@v4 add 27.1, 27.2 and 28.0, use alpine:3.20 Jan 17, 2025
@AaronDewes AaronDewes merged commit 8858ec0 into lncm:master Jan 17, 2025
15 checks passed
@lnliz lnliz deleted the 27.1_28 branch January 18, 2025 17:52
@lnliz
Copy link
Contributor Author

lnliz commented Jan 18, 2025

If CI passes on this, I'll merge it and we can deal with 28.1 later.

Thank you! And thanks for fixing the release!

@AaronDewes
Copy link
Contributor

AaronDewes commented Jan 19, 2025

I forgot to tag v27.2 and v28.0, but will do that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AaronDewes AaronDewes AaronDewes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lnliz @nolim1t @donnlee @AaronDewes