BILL-5585: Add descriptor_code support to bank account verification#247
Merged
Merged
Conversation
Stripe updated microdeposit verification from two amounts to a single 6-character descriptor code. This adds support for the new path while keeping the existing amounts path fully backwards compatible. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Postcard List tests were failing because the describe block had no before(:all) setup, so the test account had no postcards to list. Added fixture creation (and cleanup) matching the pattern used by other integration tests (e.g. Letter, Check). SelfMailer pagination test was failing because 3 items with limit=2 only produces one full page — the second page has 1 item and no next_url, causing a nil URI parse error. Added 2 more items (5 total) so two full pages of results exist. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
BankAccountVerify.new now requires exactly one of amounts or descriptor_code. Updated the two Verify unit tests that were calling BankAccountVerify.new with no arguments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rishabhromit
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: Stripe's Setup Intents API added a descriptor code-based microdeposit verification path alongside the legacy two-amount path. When a bank account is created via Setup Intents, Stripe sends a single $0.01 deposit whose statement descriptor contains a 6-character code beginning with
SM. The Ruby SDK had no support for this path, so customers whose accounts were assignedmicrodeposit_type: descriptor_codecould not complete verification through the SDK.Solution: Added
descriptor_codeas an alternative toamountsonBankAccountVerify, updated validation so exactly one of the two fields is required (not both, not neither), and addedmicrodeposit_typeto theBankAccountresponse model so callers can read which verification path applies to a given account before calling verify.Non-breaking: All existing code using
amountscontinues to work without any changes.Story
https://lobsters.atlassian.net/browse/BILL-5585
Related PR's
PHP implementation: lob/lob-php#192
Verify