BILL-5590: Add descriptor_code support to bank account verification#292
Merged
kevinpjones merged 5 commits intoJun 5, 2026
Merged
Conversation
Stripe updated microdeposit verification from two deposit amounts to a single 6-character descriptor code. This adds support for the new path while keeping the existing amounts path fully backwards compatible. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Vulnerable Libraries (17)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
rishabhromit
approved these changes
Jun 5, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- BankAccountsApi: add jest.setTimeout(60s) to fix beforeAll timeout on list tests - CampaignsApi, CardsApi, TemplatesApi: replace deprecated jest global fail() with throw - UploadsApi: remove swallowed try/catch so campaign creation errors surface properly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- CardsApi, TemplatesApi: drop description from list assertions (API returns null for unset optional fields, expect.any(String) rejects null) - CampaignsApi: probe availability before tests; skip gracefully on 403 (test key lacks campaign access) - UploadsApi: catch 403 from campaign creation in beforeAll; skip test if campaigns unavailable Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The availability probe only called list(), but create() independently 403s. Wrap the beforeAll Promise.all and the single-op create in try/catch so 403 is caught at the point of failure and marks the suite as unavailable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 27042714191Warning No base build found for commit Coverage: 72.148%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
2 similar comments
Coverage Report for CI Build 27042714191Warning No base build found for commit Coverage: 72.148%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Coverage Report for CI Build 27042714191Warning No base build found for commit Coverage: 72.148%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: Stripe's Setup Intents API added a descriptor code-based microdeposit verification path alongside the legacy two-amount path. When a bank account is created via Setup Intents, Stripe sends a single $0.01 deposit whose statement descriptor contains a 6-character code beginning with
SM. The TypeScript SDK had no support for this path, so customers whose accounts were assignedmicrodeposit_type: descriptor_codecould not complete verification through the SDK.Solution: Added
descriptor_codeas an alternative toamountsonBankAccountVerify, validated that it matches/^SM[a-zA-Z0-9]{4}$/, and addedmicrodeposit_typeto theBankAccountresponse model so callers can read which verification path applies before calling verify.Non-breaking: All existing code using
amountscontinues to work without any changes.Story
BILL-5590 (subtask of BILL-5581)
Related PRs
Changes
models/bank-account-verify.ts— Addeddescriptor_codeoptional field with setter validation (/^SM[a-zA-Z0-9]{4}$/). Madeamountsoptional (was required). Both fields remain mutually usable — callers supply exactly one.models/bank-account.ts— Addedmicrodeposit_type?: "amounts" | "descriptor_code" | nullfield andBankAccountMicrodepositTypeEnumenum.Verify
descriptor_codevalidation rejects invalid formatsmicrodeposit_typeround-trips through the modelmicrodeposit_typefield🤖 Generated with Claude Code