Skip to content

๐Ÿ› fix: file upload needs to check whether the model supports file ... #7177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coder2z
Copy link
Contributor

@coder2z coder2z commented Mar 26, 2025

file upload needs to check whether the model supports file processing

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

file upload needs to check whether the model supports file processing

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

file upload needs to check whether the model supports file processing

Copy link

vercel bot commented Mar 26, 2025

@coder2z is attempting to deploy a commit to the LobeChat Desktop Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 26, 2025
@lobehubbot
Copy link
Member

๐Ÿ‘ @coder2z

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added the ๐Ÿ› Bug Something isn't working | ็ผบ้™ท label Mar 26, 2025
Copy link
Contributor

gru-agent bot commented Mar 26, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 388de21 โœ… Finished

Files

File Pull Request
src/store/aiInfra/slices/aiModel/selectors.ts ๐ŸŸข Open #7179

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.08%. Comparing base (a28b98e) to head (388de21).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/store/aiInfra/slices/aiModel/selectors.ts 40.00% 3 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7177      +/-   ##
==========================================
- Coverage   97.20%   90.08%   -7.12%     
==========================================
  Files          13      743     +730     
  Lines        2359    53025   +50666     
  Branches      215     3468    +3253     
==========================================
+ Hits         2293    47769   +45476     
- Misses         66     5256    +5190     
Flag Coverage ฮ”
app 90.08% <40.00%> (?)
server 97.20% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx
Copy link
Contributor

arvinxx commented Mar 29, 2025

what's this feature meaning?

@coder2z
Copy link
Contributor Author

coder2z commented Mar 29, 2025

what's this feature meaning?ๆญคๅŠŸ่ƒฝๆ˜ฏไป€ไนˆๆ„ๆ€๏ผŸ

ๅฝ“ๆจกๅž‹ ่ฎพ็ฝฎ abilities.files ไธบ false ็š„ๆ—ถๅ€™ ๏ผŒๅบ”่ฏฅไธๅผ€ๅฏๆ–‡ไปถไธŠไผ ๏ผŸ

@arvinxx
Copy link
Contributor

arvinxx commented Apr 1, 2025

ไฝ†ๅฆ‚ๆžœๆ˜ฏๅผ€ๅฏ็Ÿฅ่ฏ†ๅบ“็š„่ฏๅบ”่ฏฅๆ˜ฏๆ”ฏๆŒ็š„

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


But if you open the knowledge base, it should be supported

@coder2z
Copy link
Contributor Author

coder2z commented Apr 3, 2025

ไฝ†ๅฆ‚ๆžœๆ˜ฏๅผ€ๅฏ็Ÿฅ่ฏ†ๅบ“็š„่ฏๅบ”่ฏฅๆ˜ฏๆ”ฏๆŒ็š„

้‚ฃๅบ”่ฏฅๅŒๆ—ถๅˆคๆ–ญ abilities.files ไธŽ ็Ÿฅ่ฏ†ๅบ“ ๏ผŸ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


But if you open the knowledge base, it should be supported

Then should we judge abilities.files and knowledge base at the same time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ› Bug Something isn't working | ็ผบ้™ท size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants