Skip to content

🐛 fix: Remove unused createEmptyEditorState function #7#9

Merged
canisminor1990 merged 2 commits into
masterfrom
fix/import_error
Aug 20, 2025
Merged

🐛 fix: Remove unused createEmptyEditorState function #7#9
canisminor1990 merged 2 commits into
masterfrom
fix/import_error

Conversation

@ilimei
Copy link
Copy Markdown
Collaborator

@ilimei ilimei commented Aug 20, 2025

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

🔀 变更说明 | Description of Change

Remove unused createEmptyEditorState function

📝 补充信息 | Additional Information

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lobe-editor Ready Ready Preview Comment Aug 20, 2025 2:33pm

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR cleans up dead code by removing the unused createEmptyEditorState helper and deleting an obsolete Lexical patch file.

Class diagram for removal of createEmptyEditorState function

classDiagram
    class JSONDataSource {
        +read(editor: LexicalEditor, data: any)
    }
    %% Removed function
    class createEmptyEditorState {
        -EditorState
    }
    createEmptyEditorState --|> JSONDataSource : removed
Loading

File-Level Changes

Change Details Files
Remove unused createEmptyEditorState function
  • Deleted createEmptyEditorState function
  • Removed EditorState and RootNode imports
  • Streamlined JSONDataSource implementation
src/plugins/common/data-source/json-data-source.ts
Delete obsolete Lexical patch
  • Removed lexical+0.33.1.patch file
patches/lexical+0.33.1.patch

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lobehubbot
Copy link
Copy Markdown
Member

👍 @ilimei


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@canisminor1990 canisminor1990 merged commit 0125a36 into master Aug 20, 2025
2 of 5 checks passed
@canisminor1990 canisminor1990 deleted the fix/import_error branch August 20, 2025 14:24
@lobehubbot
Copy link
Copy Markdown
Member

❤️ Great PR @ilimei ❤️


The growth of project is inseparable from user feedback and contribution, thanks for your contribution!
项目的成长离不开用户反馈和贡献,感谢您的贡献!

@lobehubbot
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants