Use the appropriate hook #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonypaulbarker
approved these changes
Oct 7, 2025
Contributor
There was a problem hiding this comment.
Functional testing looks good. I didn't see the error reported at #895 but perhaps I didn't have all the necessary conditions for triggering that.
Contributor
Author
|
Thanks @tonypaulbarker I couldn't re-produce the error either, but looks like it's now in the right place. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #895
What does this change?
As suggested in #895, uses hook_page_attachments_alter() instead of hook_page_attachments().
How to test
View source.
How can we measure success?
Look for the line
<meta name="Generator" content="Drupal 10 (LocalGov Drupal | https://localgovdrupal.org)" />(and no error message as reported on #895)Have we considered potential risks?
Just noting it was originally using the other hook because the Thunder profile did it that way: localgovdrupal/localgov_core#177 (comment)
Images
N/A
Accessibility
N/A