Skip to content

Conversation

@lazysoundsystem
Copy link
Contributor

What does this change?

Tests are failing at the moment for php 8.4:

There was 1 error:

1) Drupal\Tests\localgov\Functional\LocalGovUpdateTest::testUpdate
Exception: Deprecated function: Drupal\layout_paragraphs\Access\LayoutParagraphsBuilderAccess::access(): Implicitly marking parameter $operation as nullable is deprecated, the explicit nullable type must be used instead
include()() (Line: 576)

This includes a patch which should fix that. The change is already in the 2.1.x branch, but there hasn't been a release since it went in.

The patch is at https://www.drupal.org/files/issues/2025-09-23/fix-implicit-nullable-warnings-3502083-7.patch

How to test

Run the tests!

How can we measure success?

The tests don't break on the exception above.

Have we considered potential risks?

I don't think there are any.

Images

N/A

Accessibility

N/A

@finnlewis
Copy link
Member

Thanks @lazysoundsystem, but I think we want to patch layout_paragraphs in the composer.json where it is required.

In this case, that's localgov_paragraphs.

I also created a pull request there last week:

localgovdrupal/localgov_paragraphs#259

Sorry, I think this is now a duplicate! :)

@lazysoundsystem
Copy link
Contributor Author

@finnlewis got it. Closing.

@lazysoundsystem lazysoundsystem requested review from tonypaulbarker and removed request for tonypaulbarker October 7, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants