Improve Heartbeat Reliability#33
Merged
Merged
Conversation
- everything info: operation of the heartbeat is basically the main job of the daemon, let's not silence those away as debug logs - clarify log sites with name tagging - add an additional "actually doing the thing" log to help puzzled operators left wondering
33abff8 to
a4da302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So my heartbeats stopped working somewhere between v0.1.3 and the currently unreleased v0.3.0 main.
I've been trying to diagnose and fix, mostly increasing the observability, consistency, and persistency of heartbeat interval timing.
Just finally got to a place where I can at least see the problem, so decided to share my WIP improvements for discussion.
What looks to be happening is some kind of hang (deadlock? livelock? unclear as yet...) with the TurnGate and the heartbeat runner; see below for logs.
The commits in this branch are reasonably clear, but to recap my changes:
onemain job" of the server is to run the heartbeat reliablyRight so, now for the current diagnostics:
and there the log stop, we do not in fact see another heartbeat runner wakeup after the promised 8s quickened interval.
Will update as I find more, but wanted to share earlier than "fully fixed it" :-)