Fix compatibility with cdk<2.167.0 #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
approved these changes
Dec 4, 2024
Contributor
simonrw
left a comment
simonrw
left a comment
There was a problem hiding this comment.
Thanks for fixing this, I have experienced this today!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #96 which fixed compatibility with
aws-cdk >=2.167.0but introduced assumptions that were not holding against older AWS CDK versions (e.g.2.166.0).Symptom: When running
cdklocalit now failed with:Cannot set properties of undefined (setting 'endpoint')These kind of issues will be prevented in the future by testing against multiple older AWS CDK versions (see #98). In fact this issue here was already discovered via those initial tests!
I'll wait until we have the CI from #98 ready and then potentially have fixed more regressions for even older versions, before publishing an updated version.