Skip to content

Fix binary path in integration tests for windows #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silv-io merged 7 commits into from
Feb 5, 2026
Merged

Fix binary path in integration tests for windows #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
58a64f9
Fix binary path in integration tests for windows
silv-io Feb 5, 2026
24df4d1
Add debugging to find what the binary looks like on windows
silv-io Feb 5, 2026
f095455
Revert to normal binary path
silv-io Feb 5, 2026
98d43bf
Use bash for running integration tests
silv-io Feb 5, 2026
437a255
Optimize Makefile for binary building
silv-io Feb 5, 2026
726714c
Reintroduce binary path and create .exe on windows
silv-io Feb 5, 2026
7d14be9
Remove debugging logic
silv-io Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
BINARY_NAME=lstk
ifeq ($(OS),Windows_NT)
BINARY_NAME=lstk.exe
endif
BUILD_DIR=bin

.PHONY: build clean test test-integration lint mock-generate

build:
$(BUILD_DIR)/$(BINARY_NAME):
go build -o $(BUILD_DIR)/$(BINARY_NAME) .

build: clean $(BUILD_DIR)/$(BINARY_NAME)

clean:
rm -rf $(BUILD_DIR)

test:
@JUNIT=""; [ -n "$$CREATE_JUNIT_REPORT" ] && JUNIT="--junitfile test-results.xml"; \
go run gotest.tools/gotestsum@latest --format testdox $$JUNIT -- ./cmd/... ./internal/...

test-integration: build
test-integration: $(BUILD_DIR)/$(BINARY_NAME)
@JUNIT=""; [ -n "$$CREATE_JUNIT_REPORT" ] && JUNIT="--junitfile ../../test-integration-results.xml"; \
cd test/integration && go run gotest.tools/gotestsum@latest --format testdox $$JUNIT -- -count=1 ./...

Expand Down
5 changes: 3 additions & 2 deletions test/integration/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ func TestConfigFileCreatedOnStartup(t *testing.T) {

configFile := filepath.Join(configDir, "config.toml")

cmd := exec.Command("../../bin/lstk", "start")
cmd := exec.Command(binaryPath(), "start")
cmd.Env = env
cmd.Start()
err := cmd.Start()
require.NoError(t, err, "failed to start lstk")
defer cmd.Process.Kill()

// Poll for config file creation - check every 50ms, timeout after 2s
Expand Down
4 changes: 2 additions & 2 deletions test/integration/logout_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func TestLogoutCommandRemovesToken(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()

cmd := exec.CommandContext(ctx, "../../bin/lstk", "logout")
cmd := exec.CommandContext(ctx, binaryPath(), "logout")
output, err := cmd.CombinedOutput()

require.NoError(t, err, "lstk logout failed: %s", output)
Expand All @@ -44,7 +44,7 @@ func TestLogoutCommandSucceedsWhenNoToken(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()

cmd := exec.CommandContext(ctx, "../../bin/lstk", "logout")
cmd := exec.CommandContext(ctx, binaryPath(), "logout")
output, err := cmd.CombinedOutput()

// Should succeed even if no token
Expand Down
8 changes: 8 additions & 0 deletions test/integration/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,19 @@ package integration_test

import (
"context"
"runtime"
"testing"

"github.com/docker/docker/client"
)

func binaryPath() string {
if runtime.GOOS == "windows" {
return "../../bin/lstk.exe"
}
return "../../bin/lstk"
}

var dockerClient *client.Client
var dockerAvailable bool

Expand Down
8 changes: 4 additions & 4 deletions test/integration/start_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestStartCommandSucceedsWithValidToken(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
defer cancel()

cmd := exec.CommandContext(ctx, "../../bin/lstk", "start")
cmd := exec.CommandContext(ctx, binaryPath(), "start")
cmd.Env = append(os.Environ(), "LOCALSTACK_AUTH_TOKEN="+authToken)
output, err := cmd.CombinedOutput()

Expand All @@ -63,7 +63,7 @@ func TestStartCommandTriggersLoginWithoutToken(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
defer cancel()

cmd := exec.CommandContext(ctx, "../../bin/lstk", "start")
cmd := exec.CommandContext(ctx, binaryPath(), "start")
cmd.Env = envWithoutAuthToken()

// Capture output asynchronously
Expand Down Expand Up @@ -108,7 +108,7 @@ func TestStartCommandSucceedsWithKeyringToken(t *testing.T) {
defer cancel()

// Run without LOCALSTACK_AUTH_TOKEN should use keyring
cmd := exec.CommandContext(ctx, "../../bin/lstk", "start")
cmd := exec.CommandContext(ctx, binaryPath(), "start")
cmd.Env = envWithoutAuthToken()
output, err := cmd.CombinedOutput()

Expand All @@ -127,7 +127,7 @@ func TestStartCommandFailsWithInvalidToken(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
defer cancel()

cmd := exec.CommandContext(ctx, "../../bin/lstk", "start")
cmd := exec.CommandContext(ctx, binaryPath(), "start")
cmd.Env = append(os.Environ(), "LOCALSTACK_AUTH_TOKEN=invalid-token")
output, err := cmd.CombinedOutput()

Expand Down
Loading