Skip to content

Integration tests parallelism - docker-in-docker #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
carole-lavillonniere wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Integration tests parallelism - docker-in-docker #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2122f33
enable parallelism for tests not using docker
carole-lavillonniere Apr 28, 2026
ffe5ca9
fix tests using local user config
carole-lavillonniere Apr 28, 2026
9eef990
remove ContainerStop in tests clean-up
carole-lavillonniere Apr 28, 2026
65b2075
docker-in-docker
carole-lavillonniere Apr 28, 2026
c159a10
convert all hard integration tests to dind, parallelize
carole-lavillonniere Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions internal/runtime/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,18 @@ func (d *DockerRuntime) PullImage(ctx context.Context, imageName string, progres
}

func (d *DockerRuntime) Start(ctx context.Context, config ContainerConfig) (string, error) {
// LSTK_BIND_ALL is a test-only escape hatch: integration tests run lstk
// inside a Docker-in-Docker daemon and need nested ports reachable on the
// dind container's external interface (so the host can hit them through
// dind's port mapping). Production keeps the safer 127.0.0.1 default.
hostIP := "127.0.0.1"
if os.Getenv("LSTK_BIND_ALL") == "1" {
hostIP = "0.0.0.0"
}

containerPort := nat.Port(config.ContainerPort)
exposedPorts := nat.PortSet{containerPort: struct{}{}}
portBindings := nat.PortMap{containerPort: []nat.PortBinding{{HostIP: "127.0.0.1", HostPort: config.Port}}}
portBindings := nat.PortMap{containerPort: []nat.PortBinding{{HostIP: hostIP, HostPort: config.Port}}}

for _, ep := range config.ExtraPorts {
proto := ep.Protocol
Expand All @@ -231,7 +240,7 @@ func (d *DockerRuntime) Start(ctx context.Context, config ContainerConfig) (stri
}
p := nat.Port(ep.ContainerPort + "/" + proto)
exposedPorts[p] = struct{}{}
portBindings[p] = []nat.PortBinding{{HostIP: "127.0.0.1", HostPort: ep.HostPort}}
portBindings[p] = []nat.PortBinding{{HostIP: hostIP, HostPort: ep.HostPort}}
}

var binds []string
Expand Down
96 changes: 45 additions & 51 deletions test/integration/aws_cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,14 @@ func writeAWSProfile(t *testing.T, homeDir string) {

func TestAWSCommandInjectsEndpointAndArgs(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
startStubInDind(t, daemon, containerName)

fakeDir := writeFakeAWS(t)
analyticsSrv, events := mockAnalyticsServer(t)
// Use a fresh HOME so a real localstack profile doesn't affect the args output.
e := env.With("PATH", fakeDir).With(env.Home, t.TempDir()).
With(env.AnalyticsEndpoint, analyticsSrv.URL)
e := envWithDockerHost(t, daemon).With("PATH", fakeDir).With(env.AnalyticsEndpoint, analyticsSrv.URL)

stdout, stderr, err := runLstk(t, ctx, t.TempDir(), e, "aws", "s3", "ls")
require.NoError(t, err, "lstk aws failed: %s", stderr)
Expand All @@ -69,14 +67,13 @@ func TestAWSCommandInjectsEndpointAndArgs(t *testing.T) {

func TestAWSCommandInjectsCredentials(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
startStubInDind(t, daemon, containerName)

fakeDir := writeFakeAWS(t)
// Use a fresh HOME so no localstack profile exists; credentials are injected via env vars.
e := env.With(env.DisableEvents, "1").With("PATH", fakeDir).With(env.Home, t.TempDir())
e := envWithDockerHost(t, daemon).With(env.DisableEvents, "1").With("PATH", fakeDir)

stdout, stderr, err := runLstk(t, ctx, t.TempDir(), e, "aws", "sts", "get-caller-identity")
require.NoError(t, err, "lstk aws failed: %s", stderr)
Expand All @@ -88,16 +85,14 @@ func TestAWSCommandInjectsCredentials(t *testing.T) {

func TestAWSCommandRespectsExistingCredentials(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
startStubInDind(t, daemon, containerName)

fakeDir := writeFakeAWS(t)
// Use a fresh HOME so no localstack profile exists; the user-provided env vars are preserved.
e := env.With(env.DisableEvents, "1").
e := envWithDockerHost(t, daemon).With(env.DisableEvents, "1").
With("PATH", fakeDir).
With(env.Home, t.TempDir()).
With("AWS_ACCESS_KEY_ID", "custom-key").
With("AWS_SECRET_ACCESS_KEY", "custom-secret").
With("AWS_DEFAULT_REGION", "eu-west-1")
Expand All @@ -112,16 +107,16 @@ func TestAWSCommandRespectsExistingCredentials(t *testing.T) {

func TestAWSCommandUsesProfileWhenAvailable(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
startStubInDind(t, daemon, containerName)

fakeDir := writeFakeAWS(t)
homeDir := t.TempDir()
writeAWSProfile(t, homeDir)

e := env.With(env.DisableEvents, "1").With("PATH", fakeDir).With(env.Home, homeDir)
e := envWithDockerHost(t, daemon).With(env.DisableEvents, "1").With("PATH", fakeDir).With(env.Home, homeDir)

stdout, stderr, err := runLstk(t, ctx, t.TempDir(), e, "aws", "s3", "ls")
require.NoError(t, err, "lstk aws failed: %s", stderr)
Expand All @@ -133,12 +128,12 @@ func TestAWSCommandUsesProfileWhenAvailable(t *testing.T) {

func TestAWSCommandFailsWhenAWSCLINotInstalled(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
startStubInDind(t, daemon, containerName)

e := env.With(env.DisableEvents, "1").With("PATH", t.TempDir())
e := envWithDockerHost(t, daemon).With(env.DisableEvents, "1").With("PATH", t.TempDir())

_, stderr, err := runLstk(t, ctx, t.TempDir(), e, "aws", "s3", "ls")
require.Error(t, err)
Expand All @@ -147,16 +142,14 @@ func TestAWSCommandFailsWhenAWSCLINotInstalled(t *testing.T) {

func TestAWSCommandUsesDefaultPortWithoutConfig(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
startStubInDind(t, daemon, containerName)

fakeDir := writeFakeAWS(t)
workDir := t.TempDir()
e := env.With(env.DisableEvents, "1").
With("PATH", fakeDir).
With(env.Home, t.TempDir()) // isolate from any real config file
e := envWithDockerHost(t, daemon).With(env.DisableEvents, "1").With("PATH", fakeDir)

stdout, stderr, err := runLstk(t, ctx, workDir, e, "aws", "s3", "ls")
require.NoError(t, err, "lstk aws failed: %s", stderr)
Expand All @@ -166,10 +159,11 @@ func TestAWSCommandUsesDefaultPortWithoutConfig(t *testing.T) {

func TestAWSCommandUsesPortFromConfig(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
// container name uses port-suffixed convention when port is non-default
startStubInDind(t, daemon, containerName)

fakeDir := writeFakeAWS(t)
workDir := t.TempDir()
Expand All @@ -184,7 +178,7 @@ port = "4599"
require.NoError(t, os.MkdirAll(lstkDir, 0755))
require.NoError(t, os.WriteFile(filepath.Join(lstkDir, "config.toml"), []byte(configContent), 0644))

e := env.With(env.DisableEvents, "1").With("PATH", fakeDir)
e := envWithDockerHost(t, daemon).With(env.DisableEvents, "1").With("PATH", fakeDir)

stdout, stderr, err := runLstk(t, ctx, workDir, e, "aws", "s3", "ls")
require.NoError(t, err, "lstk aws failed: %s", stderr)
Expand Down Expand Up @@ -213,13 +207,13 @@ exit %d

func TestAWSCommandPropagatesExitCode(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
startStubInDind(t, daemon, containerName)

fakeDir := writeFakeAWSFailing(t, 42)
e := env.With(env.DisableEvents, "1").With("PATH", fakeDir)
e := envWithDockerHost(t, daemon).With(env.DisableEvents, "1").With("PATH", fakeDir)

_, stderr, err := runLstk(t, ctx, t.TempDir(), e, "aws", "s3", "ls")
require.Error(t, err, "lstk aws should fail when aws command fails")
Expand All @@ -231,6 +225,7 @@ func TestAWSCommandFailsWhenDockerNotRunning(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Windows Docker error tested separately via windowsDockerErrorEnv")
}
t.Parallel()

fakeDir := writeFakeAWS(t)
e := env.With(env.DisableEvents, "1").
Expand All @@ -244,13 +239,12 @@ func TestAWSCommandFailsWhenDockerNotRunning(t *testing.T) {

func TestAWSCommandFailsWhenEmulatorNotRunning(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)

fakeDir := writeFakeAWS(t)
analyticsSrv, events := mockAnalyticsServer(t)
e := env.With("PATH", fakeDir).
With(env.AnalyticsEndpoint, analyticsSrv.URL)
e := envWithDockerHost(t, daemon).With("PATH", fakeDir).With(env.AnalyticsEndpoint, analyticsSrv.URL)

stdout, _, err := runLstk(t, testContext(t), t.TempDir(), e, "aws", "s3", "ls")
require.Error(t, err)
Expand All @@ -262,13 +256,13 @@ func TestAWSCommandFailsWhenEmulatorNotRunning(t *testing.T) {

func TestAWSCommandHintsSetupCommandWhenProfileMissing(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
startStubInDind(t, daemon, containerName)

fakeDir := writeFakeAWS(t)
e := env.With(env.DisableEvents, "1").With("PATH", fakeDir).With(env.Home, t.TempDir())
e := envWithDockerHost(t, daemon).With(env.DisableEvents, "1").With("PATH", fakeDir)

stdout, _, err := runLstk(t, ctx, t.TempDir(), e, "aws", "s3", "ls")
require.NoError(t, err)
Expand All @@ -277,16 +271,16 @@ func TestAWSCommandHintsSetupCommandWhenProfileMissing(t *testing.T) {

func TestAWSCommandSuppressesHintWhenProfileExists(t *testing.T) {
requireDocker(t)
cleanup()
t.Cleanup(cleanup)
t.Parallel()
daemon := startEphemeralDocker(t)
ctx := testContext(t)
startTestContainer(t, ctx)
startStubInDind(t, daemon, containerName)

fakeDir := writeFakeAWS(t)
homeDir := t.TempDir()
writeAWSProfile(t, homeDir)

e := env.With(env.DisableEvents, "1").With("PATH", fakeDir).With(env.Home, homeDir)
e := envWithDockerHost(t, daemon).With(env.DisableEvents, "1").With("PATH", fakeDir).With(env.Home, homeDir)

stdout, _, err := runLstk(t, ctx, t.TempDir(), e, "aws", "s3", "ls")
require.NoError(t, err)
Expand Down
Loading
Loading