build: add JPMS Automatic-Module-Name to JAR manifest #123
Conversation
|
Hi @gezero that's fantastic; I can cut a release later this week to include the change; thank you for the contribution. Also, could I ask you to sign an ECA please? https://github.com/locationtech/proj4j/blob/master/CONTRIBUTING.md#sign-off-on-commits-and-filing-a-cla |
|
I tried to sign the ECA, I need an account first, but for some reason I cannot log in after I registered. I asked the webmaster for help. I am not sure how long until this gets resolved, sorry. |
|
@gezero I see; thank you for trying; mb the pwd reset might help? 👀 so sad unfortunately. |
|
Hmm, I tried that, but reset password does not send anything to me (not in spam, not in inbox). I tried to ask the webmaster. They have some no dot in email policy that might be relevant, hard to say before I get a reply from them. |
|
I might grab the diff from this PR and make a separate PR if that becomes a blocker 👍 |
|
Sounds good to me, thank you! |
|
There was a minor outage in their account creation workflow that prevented new accounts from completing. The issue has been resolved and hopefully, I accepted the ECA successfully. |
|
@gezero could you |
Configure the maven-jar-plugin to add an Automatic-Module-Name entry (org.locationtech.proj4j.geoapi) to the JAR manifest. This provides a stable and explicit JPMS module name for consumers using the Java module system, instead of relying on the automatically derived name based on the JAR file name. It also improves Gradle JPMS support: Gradle only puts dependencies on the module path if they either contain a module-info.class or declare an Automatic-Module-Name. Without this entry, this artifact is always kept on the classpath in modular Gradle builds and cannot be required by name from module-info.java. Signed-off-by: Jiri Peinlich <[email protected]>
|
@gezero interesting, it says that no ECA is signed for your |
|
They call it, working as expected: I had to use email address without the dot (.) -> [email protected] to register with EF |
|
oooh ic, the bot now wants you to sign the commit with this new email without a dot. |
|
I'm sorry that this bureaucracy is causing troubles 😞 |
|
But I can confirm, i see the ECA signed for the email address without a dot! |
|
I commented on the issue here: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6292 |
|
@gezero no worries, will sort it out. thank you so much and really appreciate you taking everything possible to overcome the issue. |
2 participants
Configure the maven-jar-plugin to add an Automatic-Module-Name entry (org.locationtech.proj4j.geoapi) to the JAR manifest.
This provides a stable and explicit JPMS module name for consumers using the Java module system, instead of relying on the automatically derived name based on the JAR file name. It also improves Gradle JPMS support: Gradle only puts dependencies on the module path if they either contain a module-info.class or declare an Automatic-Module-Name. Without this entry, this artifact is always kept on the classpath in modular Gradle builds and cannot be required by name from module-info.java.