Last checked - #23
Merged
Merged
Conversation
redshiftzero
requested changes
Jul 17, 2025
redshiftzero
left a comment
redshiftzero
left a comment
Contributor
There was a problem hiding this comment.
this looks great! one thought inline
| </div> | ||
| </main> | ||
| <div id="last-updated">last updated {formatted_date}</div> | ||
| <div id="last-updated">last checked {formatted_date}</div> |
Contributor
There was a problem hiding this comment.
can we show both this last checked field and the last updated field? i.e. so we can see the last time we checked if there's updates and the last time we actually updated the dashboard
| total_facilities: int | ||
|
|
||
|
|
||
| Facility = TypedDict( |
otherJL0
marked this pull request as draft
July 17, 2025 17:42
otherJL0
marked this pull request as ready for review
July 17, 2025 19:32
Collaborator
Author
|
@redshiftzero should be ready. One neat thing is now running |
| Path(output_path).parent.mkdir(parents=True, exist_ok=True) | ||
| facilities, metadata = load_facilities(input_path) | ||
| render_html(facilities, output_path, metadata) | ||
| if not os.getenv("GITHUB_ACTIONS"): |
Contributor
|
A |
redshiftzero
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16
Now that the file date extraction function is fixed, add this as a new field to the metadata to use when rendering the page.