fix: resolve issue #37 incorrect deserialization of config#38
Open
abdelrahmanomar1515 wants to merge 1 commit intoloco-rs:mainfrom
Open
fix: resolve issue #37 incorrect deserialization of config#38abdelrahmanomar1515 wants to merge 1 commit intoloco-rs:mainfrom
abdelrahmanomar1515 wants to merge 1 commit intoloco-rs:mainfrom
Conversation
removed `OpenAPIType` enum in favor of specific structs for each configuration type. This helps `serde` deserialize the config properly. The previous config structure allowed the `redoc` property on `OpenAPIConfig` to be `Some(OpenAPIType::Scalar)`. With this change this will not be allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed
OpenAPITypeenum in favor of specific structs for each configuration type. This helpsserdedeserialize the config properly. The previous config structure allowed theredocproperty onOpenAPIConfigto beSome(OpenAPIType::Scalar). With this change this will not be allowed.An existing PR #36 provided mitigation for the issue but not fully. See #37 (comment)