Skip to content

Conversation

@ofabianomartins
Copy link
Contributor

No description provided.

@ofabianomartins ofabianomartins force-pushed the feature_set_correct_create_status_return branch 3 times, most recently from c382f08 to 2a586f5 Compare September 6, 2025 15:35
@ofabianomartins ofabianomartins force-pushed the feature_set_correct_create_status_return branch 5 times, most recently from d9810b2 to 69523a6 Compare September 20, 2025 00:15
@ofabianomartins
Copy link
Contributor Author

@kaplanelad could you help me with this? I just added more types in src/prelude.rs, and Clippy started showing these errors. I don’t understand why.

error: `if _ { .. } else { .. }` is an expression
  --> src/controller/monitoring.rs:38:5
   |
38 | /     let mut is_ok: bool = true;
39 | |
40 | |     #[cfg(feature = "with-db")]
41 | |     if let Err(error) = &ctx.db.ping().await {
42 | |         tracing::error!(err.msg = %error, err.detail = ?error, "readiness_db_ping_error");
43 | |         is_ok = false;
44 | |     }
   | |_____^ help: it is more idiomatic to write: `let <mut> is_ok = if let Err(error) = &ctx.db.ping().await { ..; false } else { true };`
   |
   = note: you might not need `mut` at all
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
   = note: `-D clippy::useless-let-if-seq` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::useless_let_if_seq)]`

error: function call inside of `map_or`
   --> src/scheduler.rs:109:26
    |
109 |                         .map_or("-".to_string(), |tags| tags.join(", ")),
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map_or_else(|| "-".to_string(), |tags| tags.join(", "))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
    = note: `-D clippy::or-fun-call` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::or_fun_call)]` 

@ofabianomartins ofabianomartins force-pushed the feature_set_correct_create_status_return branch 21 times, most recently from f4fb5b3 to e244920 Compare September 20, 2025 02:37
@ofabianomartins ofabianomartins force-pushed the feature_set_correct_create_status_return branch 5 times, most recently from 77ae033 to e0244a8 Compare September 22, 2025 00:58
@ofabianomartins
Copy link
Contributor Author

@kaplanelad could you take a look here? Your last update solved the problem, but I believe it’s a good idea to fix the version of Rhai to avoid this kind of issue in the pipelines.

@ofabianomartins ofabianomartins force-pushed the feature_set_correct_create_status_return branch 4 times, most recently from fce02a3 to afaae1c Compare October 11, 2025 23:04
@ofabianomartins ofabianomartins force-pushed the feature_set_correct_create_status_return branch from 4c477e1 to fdc481f Compare October 20, 2025 01:29
@kaplanelad
Copy link
Contributor

Please pull the latest changes from master that should resolve the issue.
Ensure your PR provides proper context and includes only the most relevant updates.

@ofabianomartins
Copy link
Contributor Author

Ok. I synced the PR with master and removed all updates not related to changes the prelude. I change the position of reqwest in Cergo.toml to be possible to import in prelude. When i made the PR this was a problem.

@ofabianomartins ofabianomartins force-pushed the feature_set_correct_create_status_return branch from 4d7eb55 to 7393973 Compare November 9, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants