feat: creating UuidUniqWithDefault and UuidWithDefault #1641 #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofabianomartins
changed the title
ofabianomartins
force-pushed
the
feature_creating_more_options_off_uuid
branch
from
9de84c2 to
558fe6f
Compare
ofabianomartins
force-pushed
the
feature_creating_more_options_off_uuid
branch
2 times, most recently
from
1c4acb5 to
88efa97
Compare
kaplanelad
reviewed
Oct 19, 2025
.github/workflows/loco-new.yml
Outdated
| - name: Setup Rust cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| - name: Setup Rust clippy | ||
| run: rustup component add clippy |
Contributor
There was a problem hiding this comment.
don't think we need it. it working without it
.github/workflows/loco-rs-ci.yml
Outdated
| - name: Setup Rust cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| - name: Setup Rust clippy | ||
| run: rustup component add clippy |
src/storage/stream.rs
Outdated
| impl BytesStream { | ||
| /// Convert the `BytesStream` into an axum `Body` for HTTP responses. | ||
| /// This enables zero-copy streaming directly to the HTTP response. | ||
| #[allow(clippy::double_must_use)] |
Contributor
There was a problem hiding this comment.
Please remove it as well
ofabianomartins
force-pushed
the
feature_creating_more_options_off_uuid
branch
2 times, most recently
from
e7a3090 to
7fde65d
Compare
Contributor
Author
|
Changes applied! |
kaplanelad
reviewed
Oct 20, 2025
| @@ -1,4 +1,5 @@ | |||
| use loco_rs::prelude::*; | |||
| use axum::debug_handler; | |||
Contributor
There was a problem hiding this comment.
I don’t think this is related.
Since axum::debug_handler is now part of loco_rs::prelude::*; you can safely remove the import.
Contributor
Author
There was a problem hiding this comment.
It's true. I applied. When i send this PR the 0.16.4 is not released and i changed to pass the pipeline
kaplanelad
approved these changes
Oct 22, 2025
Contributor
Author
|
Hi @kaplanelad, you approved but not merge the PR. Something wrong? |
ofabianomartins
force-pushed
the
feature_creating_more_options_off_uuid
branch
from
301f7bc to
af27b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to add a default value to uuid column and add a default value to uniq uuid column.