Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
cargo loco seed --dumpto stream data to files instead of building a large string before writing to disk. It uses a buffered writer to lessen the access overhead. I will add the same for seeding, but that will require a bit more work and I wanted to get opinions on this first.One problem is that I couldn't find a reasonable way to access sqlx's streaming for custom queries in SeaORM, so in my case Loco is still allocating 6GB of RAM for 3 million rows. Is it alright for me to access sqlx directly here?
Sorry for the formatting shift here. Let me know if you want me to revert it.