WIP: add ability to use Tera template inheritence in emails #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtwaleson
changed the title
jtwaleson
changed the title
Contributor
Author
|
This is related to #1652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft for adding templates to emails.
I noticed that I'd like to use Tera's
extendssyntax in my emails so that I can have one file with the layout of the html email and can just use smaller ones with message-specific layout bits.Here we add a
src/mailers/shared/{base.t,subject.t,text.t}and add these to the Tera context, so that en email templates you can just use{% extends "base.t" %}.Before this change, this is not possible as we use the
one_offrendering method and Tera has very little context.Please let me know what you think.