storage: add list/stat/exists to storage instance api - #1805
Open
robertazzopardi wants to merge 1 commit into
Open
storage: add list/stat/exists to storage instance api#1805robertazzopardi wants to merge 1 commit into
robertazzopardi wants to merge 1 commit into
Conversation
Expose exists/list/stat (and *_with_policy) on Storage with the same shape as the other ops. StoreDriver and StorageStrategy require the new methods (breaking for custom impls). Replicated mirror falls back on miss/empty/error, skips empty secondary lists, and backup stays primary-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
exists/list/staton theStorageinstance api. I've tried to follow the existing read write apis closely.StoreDriverandStorageStrategynow require those methods, which is a breaking change.Mirror mode in
ReplicatedStrategyfalls back on miss/empty/error, skips empty secondary lists so they don't hide data (or swallow a primary error). Backup stays primary-only.Validation
In a fresh loco app, added mem storage to
AppContextinafter_context, added a small/api/storagecontroller, then hit it with curl / request tests: upload → exists → list (recursive + not) → stat → delete.