Initialize tempfiles and store temp files#423
Open
oxycoder wants to merge 1 commit intolocomotivecms:masterfrom
Open
Initialize tempfiles and store temp files#423oxycoder wants to merge 1 commit intolocomotivecms:masterfrom
oxycoder wants to merge 1 commit intolocomotivecms:masterfrom
Conversation
added @TempFiles ||= [] and @TempFiles << file to hold a strong reference to each Tempfile for the lifetime of the push command object, preventing GC from deleting them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Tempfile.new(...).tap { ... } in precompile returns the Tempfile with no stored reference. Ruby's GC finalizer deletes the temp file before checksum can read it. This is especially likely with large files like bundle.js since they trigger GC during memory allocation.
The fixes added @TempFiles ||= [] and @TempFiles << file to hold a strong reference to each Tempfile for the lifetime of the push command object, preventing GC from deleting them.