RST-12669 Use program basename instead of full path #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbovbel
force-pushed
the
use-basename
branch
2 times, most recently
from
0d79c22 to
c2b81bd
Compare
paulbovbel
force-pushed
the
use-basename
branch
from
c2b81bd to
fa9b56a
Compare
jprestwo
approved these changes
Mar 14, 2025
AadityaRavindran
approved these changes
Mar 14, 2025
AadityaRavindran
pushed a commit
that referenced
this pull request
Mar 14, 2025
(cherry picked from commit c8c20c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing https://github.com/locusrobotics/locus_common/pull/289, I noticed that in telegraf all caktin_virtualenv-related processes are being renamed to
/opt/locusrobot, the truncated program path. The full path was fine for ELK stack and friends, but in the new metrics world we should use the program basename.A note that https://pypi.org/project/setproctitle/ is different than BSD's setproctitle, in that it calls prctl under the hood, and somehow clobbers cmdline as well.