feat: add Go parity verification + refactor to 'parity verified' header#504
Merged
feat: add Go parity verification + refactor to 'parity verified' header#504
Conversation
- Add golang.ts parity handler with JS→Go translation - Register golang handler in parity test index - Add verified: 1.23 headers to all 20 Go functions - Fix Count.js discuss URL (was pointing to php/printf) Functions verified against golang:1.23 Docker image: - strconv: Atoi, FormatBool, FormatInt, Itoa, ParseBool, ParseInt - strings: Contains, Count, HasPrefix, HasSuffix, Index, Join, LastIndex, Repeat, Replace, Split, ToLower, ToUpper, Trim, TrimSpace 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change header from `verified: 8.3` to `parity verified: PHP 8.3` - Add test/parity/lib/config.ts as source of truth for supported languages - Add Zod validation for parity verified values in headerSchema.ts - Add displayName and parityValue to LanguageHandler interface - Update parser to read `parity verified:` key This change makes the header more explicit about what it means and enables type-safe validation against the configured parity languages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
kvz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/parity/lib/languages/golang.ts)golang:1.23Docker imageverified:header toparity verified:with type safetyHeader Change
Before:
// verified: 8.3After:
// parity verified: PHP 8.3This makes the header more explicit and enables type-safe validation:
test/parity/lib/config.tsas source of truth for supported languagesheaderSchema.tsagainst parity configdisplayNameandparityValuetoLanguageHandlerinterfaceFunctions Verified
Go (20):
Total verified: 199 (164 PHP + 15 Python + 20 Go)
Test plan
yarn test)🤖 Generated with Claude Code