Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update text on patches #445

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joaniekube
Copy link
Contributor

@joaniekube joaniekube commented Jan 30, 2025

Content Description

  • Update the text related to patches
  • Restructure doc for a bit more clarity
  • Add further explanation for wildcards in patches and context variable
  • Refine examples for clarity

Preview Link

Internal Reference

N/A

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for vcluster-docs-site ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a08ccc3
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/67e2ed34181f6c000859edf0
😎 Deploy Preview https://deploy-preview-445--vcluster-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joaniekube joaniekube force-pushed the joan_test-patch branch 3 times, most recently from 70bfada to b538209 Compare January 30, 2025 08:26
Copy link
Contributor

@Piotr1215 Piotr1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaniefromtheblock I had to approve/trigger the vale workflow (it needs to be done for all external contributors). As you can see, there are some vale rules violations. Could you please fix those? Please refer to the CONTRIBUTING.md to learn more about styling guidelines and working with vale.

Tip

you can find the exact rules violations in the Files changed tab

change file location

change file location

change file location

change file location

change file location

change file location

change file location

change file location

change file location

change file location

change file location

remove admonitions

change file location

change file location

change file location

update

update link

update link

update link

update link

update link

update link

update link

update link

update link

update first line

updates for linter

update text for clarity

update text for consistency

slight rewrite
Copy link
Contributor

@deniseschannon deniseschannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, but otherwise, I think it looks great!

@joaniekube joaniekube requested a review from a team as a code owner February 26, 2025 00:41
@joaniekube
Copy link
Contributor Author

joaniekube commented Feb 26, 2025

@deniseschannon and @sowmyav27 Could you please take another look at this PR? Please let me know what additional changes may be needed or approve if ready.

@joaniekube
Copy link
Contributor Author

@Piotr1215 Could you please approve this PR ?

Copy link
Contributor

@sowmyav27 sowmyav27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest comments here #445 (comment)

Copy link
Contributor

@deniseschannon deniseschannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaniekube and I discussed offline on how the original code blocks were being templated but neither of us were aware of it and how we need to bring back the template using the props variables and how to generalize the explanations.

@Piotr1215 Piotr1215 changed the title Update text on patches refactor: update text on patches Mar 5, 2025
@joaniekube
Copy link
Contributor Author

Hi @deniseschannon PTAL. I applied suggestions. Can this be approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants