-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update text on patches #445
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vcluster-docs-site ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
70bfada
to
b538209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaniefromtheblock I had to approve/trigger the vale
workflow (it needs to be done for all external contributors). As you can see, there are some vale
rules violations. Could you please fix those? Please refer to the CONTRIBUTING.md to learn more about styling guidelines and working with vale.
Tip
you can find the exact rules violations in the Files changed
tab
change file location change file location change file location change file location change file location change file location change file location change file location change file location change file location change file location remove admonitions change file location change file location change file location update update link update link update link update link update link update link update link update link update link update first line updates for linter update text for clarity update text for consistency slight rewrite
fb57a04
to
4c6139c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, but otherwise, I think it looks great!
Co-authored-by: nebelsprachen <[email protected]>
@deniseschannon and @sowmyav27 Could you please take another look at this PR? Please let me know what additional changes may be needed or approve if ready. |
@Piotr1215 Could you please approve this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest comments here #445 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaniekube and I discussed offline on how the original code blocks were being templated but neither of us were aware of it and how we need to bring back the template using the props
variables and how to generalize the explanations.
Hi @deniseschannon PTAL. I applied suggestions. Can this be approved? |
Content Description
context
variablePreview Link
Internal Reference
N/A