Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates 'spaces' to 'namespaces' #549

Merged
merged 4 commits into from
Mar 25, 2025
Merged

fix: updates 'spaces' to 'namespaces' #549

merged 4 commits into from
Mar 25, 2025

Conversation

joaniekube
Copy link
Contributor

Content Description

  • spaces was replaced with namespaces. Updating remaining instances of spaces to namespaces.

Preview Link

Internal Reference

Closes DOC-336

Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for vcluster-docs-site ready!

Name Link
🔨 Latest commit 0b1d93e
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/67e1358d275b9e0008933a64
😎 Deploy Preview https://deploy-preview-549--vcluster-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

| `loft create vcluster` | `vcluster create --driver=platform` | `vcluster platform create vcluster` | Following flags have been **removed**:<br/>`--delete-after`<br/>`--disable-direct-cluster-endpoint`<br/>`--sleep-after`<br/>`--space` (Please use `--namespace` instead)<br/><br/>Following flags have been **changed**:<br/>`--version` was renamed to `--template-version` |
| `loft delete vcluster` | `vcluster delete --driver=platform` | `vcluster platform delete vcluster` | Following flags have been **removed**:<br/>`--cluster` (vCluster platform handles this transparently in the background)<br/>`--space` (vCluster platform handles this transparently in the background)<br/>`--delete-space` (Please use `--delete-namespace`) |
| `loft create vcluster` | `vcluster create --driver=platform` | `vcluster platform create vcluster` | Following flags have been **removed**:<br/>`--delete-after`<br/>`--disable-direct-cluster-endpoint`<br/>`--sleep-after`<br/>`--namespace` (Please use `--namespace` instead)<br/><br/>Following flags have been **changed**:<br/>`--version` was renamed to `--template-version` |
| `loft delete vcluster` | `vcluster delete --driver=platform` | `vcluster platform delete vcluster` | Following flags have been **removed**:<br/>`--cluster` (vCluster platform handles this transparently in the background)<br/>`--namespace` (vCluster platform handles this transparently in the background)<br/>`--delete-namespace` (Please use `--delete-namespace`) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Loft.no-vcluster-platform] Prefer using 'the platform' instead of 'vCluster platform'

@joaniekube joaniekube changed the title fix: updates 'spaces' to 'namespaces fix: updates 'spaces' to 'namespaces' Mar 21, 2025
@joaniekube joaniekube marked this pull request as ready for review March 24, 2025 10:34
@joaniekube joaniekube requested a review from a team as a code owner March 24, 2025 10:34
Copy link
Contributor

@Piotr1215 Piotr1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the changes to command files in the cli folder (except the 0-20...mdx) to take effect, we will need to address them in the source repo in this folder. Otherwise looks good!

@Piotr1215 Piotr1215 merged commit 6e5c881 into main Mar 25, 2025
6 of 7 checks passed
@Piotr1215 Piotr1215 deleted the namespaces branch March 25, 2025 11:38
@Piotr1215 Piotr1215 added the follow-up Create a follow-up issue in linear label Mar 25, 2025
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up Create a follow-up issue in linear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants