fix: update eso partials and adjust partials generate script #589
Conversation
✅ Deploy Preview for vcluster-docs-site ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -105,8 +105,8 @@ func main() { | |||
|
|
|||
| util.DefaultRequire = false | |||
| versionDir := os.Args[1] | |||
| jsonSchemaPath := filepath.Join(versionDir, "vcluster.schema.json") | |||
| defaultValues := filepath.Join(versionDir, "default_values.yaml") | |||
| jsonSchemaPath := filepath.Join(versionDir, "values.schema.json") | |||
There was a problem hiding this comment.
Probably I'm missing some context, but in order it to work with the vcluster repo I had to rename those files 🤔. (cc @Piotr1215 @joaniekube)
There was a problem hiding this comment.
@hidalgopl can you please confirm? I'm not sure if the files have to be renamed.
There was a problem hiding this comment.
yeah, renaming these will break the CI that updates partials.
Could you describe @johannesfrey what are you trying to do and what did not work?
There was a problem hiding this comment.
Ah, didn't know that we have a CI step for this here in vcluster. So I guess I can delete this PR as the content here will be a auto generated PR when the next beta/rc is created?
johannesfrey
force-pushed
the
update-wording-eso-schema
branch
3 times, most recently
from
3191c8a to
e6d30fb
Compare
johannesfrey
force-pushed
the
update-wording-eso-schema
branch
from
e6d30fb to
948d2dc
Compare
|
Closing because this will automatically done by CI for the next beta/rc release. |
Content Description
Copies over the adjusted ESO comments and adjusts the partials script to use the correct files.
NOTE: Should be merged after the ESO comments have been merged in vcluster and backported to 0.24. Therefore, this PR is in draft.
Preview Link
Internal Reference
Part of ENG-6173