feat(e2e): snapshot restore e2e tests #2563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
adriankabala
changed the title
sowmyav27
requested changes
Mar 20, 2025
sowmyav27
requested changes
Apr 1, 2025
| gomega.Eventually(func() int { | ||
| services, err := f.HostClient.CoreV1().Services(vClusterDefaultNamespace).List(f.Context, metav1.ListOptions{ | ||
| LabelSelector: "snapshot=delete", | ||
| //Check configmap created before snapshot is available |
There was a problem hiding this comment.
why do we need a polling here? When vCluster is Running, the configmaps should just be present isn;t it?
So just this should work?
configmaps, err := f.VClusterClient.CoreV1().ConfigMaps(defaultNamespace).List(f.Context, metav1.ListOptions{
LabelSelector: "snapshot=restore",
})
if len(configmaps.Items) != 1 {
return map[string]string{}
}
restoredConfigmap := configmaps.Items[0]
framework.ExpectNoError(err)
Similar comment for secrets and deployments below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind test
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?