Add the "project" column for vcluster list command when driver flag is set to platform #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApsTomar
force-pushed
the
add-project-in-list-result
branch
from
2668ec6 to
4cdd1d0
Compare
sort imports lint fixes
ApsTomar
force-pushed
the
add-project-in-list-result
branch
from
4cdd1d0 to
bef307b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-6618
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster list will now have project column as well in the output in case driver flag is set to platform
What else do we need to know?
I've separated out the print functions for both drivers (helm and platform). The reason for doing that is- this change would add more if-else blocks within already existing if-else scenarios and would inhibit the readability. Now both the print methods are placed in the respective files i.e. no cross-file function calling.
Test Artifacts:
Tabular Output:
JSON Output:
Without
--driver platform, the result is as usual: