-
Notifications
You must be signed in to change notification settings - Fork 494
ci: build head
docker images on changes in main
#2785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use default branch variable here ${{ github.event.repository.default_branch }}
87aa8ec
to
b4dd4d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments and suggestions. Also we should at least run unit and helm tests before triggering the workflow, something like in the release workflow:
- name: Execute unit tests
run: ./hack/test.sh
- name: Run Helm Unit Tests
run: |
helm plugin install https://github.com/helm-unittest/helm-unittest --version v0.4.4
helm unittest chart
Good idea! Added unit tests and addressed other comments |
Builds docker images with `head-<architecture>` tags on every push to main. Pushes images only if executed on the main branch.
405d1fa
to
c78220a
Compare
Add Docker build step for main branch commits
main
branch.head-<architecture>
, e.g.,vcluster-oss:head-arm64v8
orvcluster-oss:head-amd64
.What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)References OPS-148