feat: add ability to force sync an event into default namespace #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaferson
reviewed
May 19, 2025
| @@ -49,6 +50,11 @@ func (s *eventMapper) HostToVirtual(ctx *synccontext.SyncContext, req types.Name | |||
| err = IgnoreAcceptableErrors(err) | |||
| if err != nil { | |||
| klog.Infof("Error retrieving involved object for %s/%s: %v", req.Namespace, req.Name, err) | |||
| } else if pObj.GetAnnotations()[constants.SyncResourceAnnotation] == "true" { | |||
| return types.NamespacedName{ | |||
| Namespace: "default", | |||
There was a problem hiding this comment.
maybe move this into a variable or a constant?
Just a question, why are we hardcoding it to the default ns?
There was a problem hiding this comment.
maybe move this into a variable or a constant?
Ok, will do.
Just a question, why are we hardcoding it to the default ns?
If the event is not related to any specific synced resource then we don't have anything to go by to make the ns decision. Thus "default" seemed like a reasonable fallback. I've also considered adding an annotation for the virtual namespace, but default is enough for the initial use case.
There was a problem hiding this comment.
I see, that makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-6860
Please provide a short message that should be published in the vcluster release notes
Added ability to force sync Events that don't have an
involvedObjectthat is synced from vCluster. These events will be synced into the default namespace.What else do we need to know?