[ENG-8736] Fix: quote .Release.Name in Helm label values to prevent YAML int coercion#3592
Merged
FabianKramm merged 1 commit intomainfrom Feb 20, 2026
Merged
[ENG-8736] Fix: quote .Release.Name in Helm label values to prevent YAML int coercion#3592FabianKramm merged 1 commit intomainfrom
FabianKramm merged 1 commit intomainfrom
Conversation
…oercion When the Helm release name is a purely numeric string (e.g. "1"), YAML parsers interpret unquoted label values as integers rather than strings. This causes yaml.UnmarshalStrict to fail with a type-mismatch error in the vCluster pod at startup. Add the `quote` pipeline function to all `release:` and `vcluster.loft.sh/managed-by:` label values that use .Release.Name directly as a standalone value in: - chart/templates/statefulset.yaml - chart/templates/service.yaml - chart/templates/networkpolicy.yaml - chart/templates/etcd-statefulset.yaml - chart/templates/etcd-service.yaml - chart/templates/pod-disruption-budget.yaml Resolves ENG-8736 Co-Authored-By: pascal.breuninger (🤖) <noreply@loft.sh>
FabianKramm
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
| quotepipeline to all standalone.Release.Nameusages inrelease:andvcluster.loft.sh/managed-by:label values across 6 Helm template filesProblem
When the Helm release name is a purely numeric string (e.g.
1), YAML parsers interpret unquoted label values as integers rather than strings. The vCluster binary callsyaml.UnmarshalStricton the renderedconfig.yamland fails with a type-mismatch error, causing the pod to crash-loop.Changes
Added
| quotetorelease: {{ .Release.Name }}andvcluster.loft.sh/managed-by: {{ .Release.Name }}label values in:chart/templates/statefulset.yaml(2 occurrences)chart/templates/service.yaml(1 occurrence)chart/templates/networkpolicy.yaml(7release:+ 6managed-by:= 13 occurrences)chart/templates/etcd-statefulset.yaml(2 occurrences)chart/templates/etcd-service.yaml(1 occurrence)chart/templates/pod-disruption-budget.yaml(1 occurrence)name:fields and embedded forms likevc-config-{{ .Release.Name }}are intentionally unchanged (they are already strings by context or embedding).Related
Test plan
go build -mod vendor ./cmd/vclusterctl/passeshelm lint chartpasses (1 chart linted, 0 failed)Generated by pascal.breuninger (🤖) (VibePod). Review carefully before merging.