fix(vind): concurrent cluster create may fail#3954
Open
fatih-acar wants to merge 1 commit into
Open
Conversation
Let Docker's IPAM atomically pick a free subnet from its default-address-pools. Picking a subnet ourselves opens a window where two parallel callers can both observe the same "free" subnet and then race to claim it, producing "Pool overlaps with other one on this address space" under concurrent `vcluster create` runs. Signed-off-by: Fatih Acar <fatih@opsmill.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let Docker's IPAM atomically pick a free subnet from its default-address-pools. Picking a subnet ourselves opens a window where two parallel callers can both observe the same "free" subnet and then race to claim it, producing "Pool overlaps with other one on this address space" under concurrent
vcluster createruns.What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where creating multiple vind clusters in parallel on the same Docker host would intermittently fail due to race conditions when probing for free subnets.
What else do we need to know?