fix(snapshot): unblock PVC restore and warn on silent skip (#3951)#3964
Open
Roshr2211 wants to merge 1 commit into
Open
fix(snapshot): unblock PVC restore and warn on silent skip (#3951)#3964Roshr2211 wants to merge 1 commit into
Roshr2211 wants to merge 1 commit into
Conversation
) Add persistentvolumeclaims/status to the syncer Role so virtual->host status sync no longer fails with 'cannot update resource persistentvolumeclaims/status'. Make the skip path louder: emit a Warning event explaining that the existing PVC blocked the restore and snapshot data was not applied. Skip semantics preserved as a safety default.
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3951.
persistentvolumeclaims/statusto the syncer Role so theStatus().Update()call inpatcher.ApplyObjectPatchsucceeds duringPVC sync. Without this, restoring a PVC from a vcluster snapshot
(after deleting the existing one) leaves it stuck
Pendingwithcannot update resource 'persistentvolumeclaims/status' in API group ''.existing PVC, the restorer silently marks it
Skippedand emits ageneric
Normalevent. Users assume the restore worked and lose thesnapshot's data. Upgrade the event to
Warning, expand the message toexplain the cause and the required action, and add an
Infofat thedetection site so the skip appears in normal logs. Skip semantics
are preserved as a safety default — replacing a bound PVC would
destroy live data.
Verification
as the syncer ServiceAccount. Before: 403 Forbidden matching the exact error from PVC restore from vcluster snapshot fails #3951. After: 200 OK,
`status.phase=Bound` set, `subresource=status` in managedFields.
syncs Bound to host with no `persistentvolumeclaims/status` errors in syncer logs.
`chart/tests/role_test.yaml`.
`inProgressPVCReconcileFinished` covering the Skipped / Completed / Failed branches.
Test plan
Completed/Failed branches unchanged