fix(ci): fail curl on HTTP errors in download-latest-cli job#3986
Open
chemicoholic21 wants to merge 1 commit into
Open
fix(ci): fail curl on HTTP errors in download-latest-cli job#3986chemicoholic21 wants to merge 1 commit into
chemicoholic21 wants to merge 1 commit into
Conversation
- Added -f flag to curl to fail on HTTP 4xx/5xx - Added --retry 3 --retry-delay 5 for transient failures - Added ELF binary verification check Fixes failing upgrade-test CI job on PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bugfix
resolves #
Fixed an issue where the E2E upgrade-test CI job downloaded HTML error pages instead of the vCluster binary because
curldid not fail on HTTP errors.E2E Tests
Default Test Execution
The mandatory PR suite runs automatically. Only specify additional test suites below if needed.