fix: CRD sync race in vcluster HA#3993
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
loft-bot
reviewed
Jun 12, 2026
roehrijn
reviewed
Jun 12, 2026
mfranczy
approved these changes
Jun 12, 2026
loft-bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
(cherry picked from commit 153381c)
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
loft-bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
(cherry picked from commit 153381c)
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
jjaferson
added a commit
that referenced
this pull request
Jun 12, 2026
jjaferson
added a commit
that referenced
this pull request
Jun 14, 2026
(cherry picked from commit 153381c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes race condition when syncing CRDs in vcluster HA
Log messages from the conflict being retried
What issue type does this pull request address? (keep at least one, remove the others)
kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENGCP-906
Please provide a short message that should be published in the vcluster release notes
Fixes CRD sync race in vcluster HA
What else do we need to know?
E2E Tests
Default Test Execution
The mandatory PR suite runs automatically. Only specify additional test suites below if needed.
Adding New Test Suites
When adding a new ginkgo test suite:
Additional test suites
Additional test suite(s) that will be executed before the mandatory PR suite: