Skip to content

fix: CRD sync race in vcluster HA#3993

Merged
jjaferson merged 1 commit into
loft-sh:mainfrom
jjaferson:ENGCP-906
Jun 12, 2026
Merged

fix: CRD sync race in vcluster HA#3993
jjaferson merged 1 commit into
loft-sh:mainfrom
jjaferson:ENGCP-906

Conversation

@jjaferson

@jjaferson jjaferson commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fixes race condition when syncing CRDs in vcluster HA

Log messages from the conflict being retried

[34mINFO�[0m	translate/translate.go:401	CRD found in virtual cluster, checking versions	{"component": "vcluster", "crd": "externalsecrets.external-secrets.io", "groupVersionKind": "external-secrets.io/v1, Kind=ExternalSecret"}
[34mINFO�[0m	translate/translate.go:426	Updating CRD in virtual cluster with new version	{"component": "vcluster", "crd": "externalsecrets.external-secrets.io", "version": "v1"}
[34mINFO�[0m	commandwriter/commandwriter.go:128	Adding GroupVersion external-secrets.io v1 to ResourceManager	{"component": "vcluster", "component": "apiserver", "location": "handler.go:304"}
[34mINFO�[0m	commandwriter/commandwriter.go:128	all system priority classes are created successfully or already exist.	{"component": "vcluster", "component": "apiserver", "location": "storage_scheduling.go:139"}
[34mINFO�[0m	translate/translate.go:429	CRD update conflict, retrying with latest ResourceVersion	{"component": "vcluster", "crd": "externalsecrets.external-secrets.io", "version": "v1"}
[34mINFO�[0m	translate/translate.go:421	CRD in virtual cluster already has desired version	{"component": "vcluster", "crd": "externalsecrets.external-secrets.io", "version": "v1"}
[34mINFO�[0m	resources/register.go:110	Created ExternalSecret syncer	{"component": "vcluster"}
[34mINFO�[0m	setup/managers.go:49	Starting local manager...	{"component": "vcluster"}

What issue type does this pull request address? (keep at least one, remove the others)
kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENGCP-906

Please provide a short message that should be published in the vcluster release notes
Fixes CRD sync race in vcluster HA

What else do we need to know?

E2E Tests

Default Test Execution

The mandatory PR suite runs automatically. Only specify additional test suites below if needed.

Adding New Test Suites

When adding a new ginkgo test suite:

  • Add labels to the test suite
  • Update label-filter section below to execute the new test suite
  • Verify test suite runs in CI/CD pipeline

Additional test suites

Additional test suite(s) that will be executed before the mandatory PR suite:

none

@jjaferson

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jjaferson jjaferson marked this pull request as ready for review June 12, 2026 08:56
@jjaferson jjaferson requested a review from a team as a code owner June 12, 2026 08:56
Comment thread pkg/util/translate/translate.go Outdated
Comment thread pkg/util/translate/translate.go Outdated
Comment thread pkg/util/translate/translate.go Outdated
@jjaferson jjaferson merged commit 153381c into loft-sh:main Jun 12, 2026
19 of 20 checks passed
loft-bot pushed a commit that referenced this pull request Jun 12, 2026
@loft-bot

Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
v0.34
v0.35

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

loft-bot pushed a commit that referenced this pull request Jun 12, 2026
@loft-bot

Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
v0.34
v0.35

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

jjaferson added a commit that referenced this pull request Jun 12, 2026
(cherry picked from commit 153381c)

Co-authored-by: Jose Silva <jose.silva@loft.sh>
jjaferson added a commit that referenced this pull request Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants