Implement auto context inclusion on text selection #2017
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| handleSelectionChange() { | ||
| const activeView = this.app.workspace.getActiveViewOfType(MarkdownView); | ||
| if (!activeView || !activeView.editor) { | ||
| return; | ||
| } | ||
|
|
||
| const editor = activeView.editor; | ||
| const selectedText = editor.getSelection(); | ||
|
|
||
| // Only process non-empty selections | ||
| if (!selectedText || !selectedText.trim()) { | ||
| return; |
There was a problem hiding this comment.
The new selectionchange handler only calls handleSelectionChange when the editor selection contains text, but it never clears the selected-text context when the user deselects everything. After selecting a fragment once, selectedTextContexts remains populated indefinitely, so subsequent chats keep reusing the stale selection and Chat.tsx suppresses active-note context via effectiveIncludeActiveNote even though nothing is currently selected. Consider calling clearSelectionContext() whenever editor.getSelection() returns an empty string to avoid persisting outdated context.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
When focus shifts to copilot chat input, the selection is lost, so we can't clear it from context otherwise it won't ever be added to context.
Addresses #1967