fix(rules): allow multi-character values for da locale in alpha_num#5161
Open
greymoth-jp wants to merge 1 commit into
Open
fix(rules): allow multi-character values for da locale in alpha_num#5161greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 9e34870 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for vee-validate-docs canceled.
|
✅ Deploy Preview for vee-validate-v5 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔎 Overview
The
da(Danish) entry in thealphanumerictable is missing the*quantifier, soalpha_numwithlocale: 'da'only matches a single character and rejects any real multi-character value.This looks like a transcription typo, not an intended single-character rule:
alphanumerictable uses*.daentries in the siblingalpha,alphaSpaces, andalphaDashtables all already have*.da-DKtoo (/^[0-9A-ZÆØÅ]+$/i).🤓 Code snippets/examples (if applicable)
Added a regression test in
alpha_num.spec.tsand a changeset. The rules package tests pass.✔ Issues affected
None filed.