[FSTORE-1693] Null values in feature group causes built-in transformation function label encoder to Fail#539
Draft
manu-sj wants to merge 3 commits into
Draft
[FSTORE-1693] Null values in feature group causes built-in transformation function label encoder to Fail#539manu-sj wants to merge 3 commits into
manu-sj wants to merge 3 commits into
Conversation
860a86f to
3bd265d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Null values in the column used for a label encoder causes it to cash with the error .
Root Cause:
Hopsworks statistics retturns
Noneas a unique element if it is present in a column. This cause the label_encoder to fail because the None cannot be used as key in a dictionary for label value lookup.Fix Done:
Ignore None while creating a dictionary for label value look up. Null values are not encoded and retruned as None itself so that the user can perform any imputation strategy.
JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1693
Priority for Review: -
Related PRs: -
How Has This Been Tested?
Checklist For The Assigned Reviewer: