Add button to set label for accounts#29
Open
schouhy wants to merge 2 commits into
Open
Conversation
erhant
reviewed
Jul 24, 2026
| : m_logosAPI->getClient(LEZ_MODULE)->invokeRemoteMethod( | ||
| LEZ_MODULE, "register_private_account", | ||
| QVariantList{accountIdHex.trimmed()}, | ||
| NO_TIMEOUT).toString(); |
There was a problem hiding this comment.
feels funny to do this for the sake of timeouts, I wonder if logos-core team has plans for a more ergonomic approach on this 🤔
erhant
reviewed
Jul 24, 2026
| return false; | ||
| const QString programOwner = doc.object().value(QStringLiteral("program_owner")).toString(); | ||
| return std::any_of(programOwner.cbegin(), programOwner.cend(), | ||
| [](QChar c) { return c != QLatin1Char('0'); }); |
There was a problem hiding this comment.
bro god bless Rust closures, how ugly is C++ 🙏🏻
erhant
reviewed
Jul 24, 2026
There was a problem hiding this comment.
this is from #28 I think, right? same comment applies here
moudyellaz
approved these changes
Jul 24, 2026
moudyellaz
left a comment
moudyellaz
left a comment
Contributor
There was a problem hiding this comment.
lgtm, thanks. Left a small comment
| // Both feed the transfer/withdraw "from"/"to" account-picker combo boxes, where an | ||
| // uninitialized account isn't a usable sender or recipient — unlike m_accountModel | ||
| // (unfiltered), which AccountsPanel needs to keep showing them on for initialization. | ||
| m_filteredAccountModel->setOnlyInitialized(true); |
Contributor
There was a problem hiding this comment.
is_initialized comes from a per-account network read that defaults to false when the sequencer call fails, so one failed read during a refresh drops good accounts from this picker until the next refresh. Could we keep the last-known value like balances do?
schouhy
force-pushed
the
schouhy/add-labels
branch
from
July 24, 2026 21:29
051c565 to
275415f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on PR #28
Note: currently the LEZ wallet core module does not support removing/editing existing labels. We therefore don't support those here either.