chore: static link go-wallet-sdk

[dlipicar]

Bump go-wallet-sdk
Link the lib statically instead of dynamically.

[Copilot]

Pull request overview

This PR converts the go-wallet-sdk dependency from dynamic linking to static linking, eliminating the need to distribute separate shared library files with the wallet module plugin.

Key Changes

• Updates go-wallet-sdk to commit 0938a704 which includes static library build support
• Builds libgowalletsdk.a static library instead of shared libraries (.so, .dylib)
• Adds platform-specific whole-archive linker flags and macOS framework dependencies required for static linking
• Removes dynamic library installation and install_name_tool fix-up logic that is no longer needed

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
flake.nix	Updates go-wallet-sdk dependency to newer commit with static linking support
flake.lock	Updates lock file to match new go-wallet-sdk commit hash and metadata
nix/lib.nix	Changes build to produce static library (.a) instead of shared library (.so/.dylib)
metadata.json	Removes dynamic library files from include list since they're no longer shipped
fix_wallet_install_name.cmake	Removes entire file as install_name_tool fixes are unnecessary with static linking
CMakeLists.txt	Updates library search, linking configuration with whole-archive flags, and macOS framework dependencies; removes dynamic library copying and install_name_tool commands

Comments suppressed due to low confidence (1)

nix/lib.nix:113

• Since the go-wallet-sdk library is now statically linked into the wallet_module_plugin, copying the static library file libgowalletsdk.a to the output directory may be unnecessary. Static libraries are compiled into the binary at link time and don't need to be distributed separately. Consider removing this installation step unless there's a specific need to distribute the static library for other purposes.

    # Copy the wallet library if it exists (check both lib/ and modules/ directories)
    if [ -f lib/libgowalletsdk.a ]; then
      cp lib/libgowalletsdk.a $out/lib/
      echo "Copied libgowalletsdk.a from lib/ to $out/lib/"
    elif [ -f modules/libgowalletsdk.a ]; then
      cp modules/libgowalletsdk.a $out/lib/
      echo "Copied libgowalletsdk.a from modules/ to $out/lib/"
    else
      echo "Warning: No wallet library found in lib/ or modules/"
      echo "Contents of lib/:"
      ls -la lib/ 2>/dev/null || echo "lib/ directory does not exist"
      echo "Contents of modules/:"
      ls -la modules/ 2>/dev/null || echo "modules/ directory does not exist"
    fi

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The macOS frameworks CoreFoundation and Security are linked with PUBLIC visibility, which exports these dependencies to consumers of wallet_module_plugin. Since this appears to be a plugin library and these frameworks are implementation details needed for the static go-wallet-sdk library, consider using PRIVATE visibility instead to avoid exposing these dependencies unnecessarily.

Suggested change

	target_link_libraries(wallet_module_plugin PUBLIC "-framework CoreFoundation")
	target_link_libraries(wallet_module_plugin PUBLIC "-framework Security")
	target_link_libraries(wallet_module_plugin PRIVATE "-framework CoreFoundation")
	target_link_libraries(wallet_module_plugin PRIVATE "-framework Security")

[Copilot]

The comment mentions "accounts library not found" but should refer to the wallet library. This appears to be a copy-paste error from another part of the codebase.

Suggested change

	COMMENT "Updating library paths for macOS (accounts library not found)"
	COMMENT "Updating library paths for macOS (wallet library not found)"

[Copilot]

The static library is linked twice: once on line 219 via target_link_libraries, and again via target_link_options with whole-archive flags on lines 223/226. This redundant linking should be removed. Consider removing line 219 and keeping only the whole-archive linking, or use only the basic linking if the whole-archive approach is not needed.