Skip to content

Conversation

@SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Jun 25, 2025

I added store sync stuff!

@SionoiS SionoiS self-assigned this Jun 25, 2025
@vercel
Copy link

vercel bot commented Jun 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-waku-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 4:18pm

Comment on lines +94 to +96
--store-sync-interval=300 \
--store-sync-range=3600 \
--store-sync-relay-jitter=20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can store sync be enabled without those arguments for simplicity's sake aka good defaults?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the values used are the default ones and can be omitted.

Copy link
Collaborator

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SionoiS SionoiS added this to Waku Jun 26, 2025
@SionoiS SionoiS moved this to Code Review / QA in Waku Jun 26, 2025
@SionoiS
Copy link
Contributor Author

SionoiS commented Jul 3, 2025

Can anyone merge this? @jm-clius @fryorcraken

@jm-clius
Copy link
Collaborator

jm-clius commented Jul 3, 2025

Can anyone merge this?

Oh, it's a cspell error on the word "statusteam".
I thought I fixed this by adding to the dictionary in 3e0e4e2 but it seems not that simple. I cannot bypass the merge requirements directly without disabling it for the repo. Not sure if we want to do this for the docs repo, @fryorcraken?

@SionoiS SionoiS merged commit 0df0fcb into develop Jul 3, 2025
3 of 4 checks passed
@SionoiS SionoiS deleted the feat--add-store-sync-entrees branch July 3, 2025 17:11
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants