document reliable channels #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks
fryorcraken
requested review from
adklempner,
danisharora099,
vpavlin and
weboko
weboko
reviewed
Sep 9, 2025
| It is up to you how to generate an id. Every participant **must** have a different id. | ||
|
|
||
| ```js | ||
| const senderId = generateRandomStringId(); |
Contributor
There was a problem hiding this comment.
I am wondering if uuid would be enough here
Suggested change
| const senderId = generateRandomStringId(); | |
| const senderId = uuid(); |
Contributor
Author
There was a problem hiding this comment.
I want to leave it up to the dev here because it is best if they persist it locally.
weboko
reviewed
Sep 9, 2025
| ## Import Waku SDK | ||
|
|
||
| ```shell | ||
| npm install @waku/[email protected] |
Contributor
There was a problem hiding this comment.
it's ok to mention @waku/[email protected] as we will have it released in a week or two
Contributor
There was a problem hiding this comment.
Suggested change
| npm install @waku/sdk@0.0.35-4d5c152.0 | |
| npm install @waku/sdk@0.0.35 |
Contributor
Author
There was a problem hiding this comment.
will wait for the release to update doc.
weboko
approved these changes
Sep 9, 2025
Contributor
weboko
left a comment
weboko
left a comment
There was a problem hiding this comment.
looks good, let's wait with this PR till logos-messaging/js-waku#2576 is merged
fryorcraken
force-pushed
the
reliable-channels
branch
from
8a79765 to
58fbf05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.