Skip to content

Conversation

@weboko
Copy link
Collaborator

@weboko weboko commented Jun 3, 2025

Problem / Description

When libp2p accidentaly introduced breaking change in minor update it broke js-waku's consumers.

Solution

Hard set libp2p package versions.

Notes


Checklist

  • [ ] Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@weboko weboko requested a review from a team as a code owner June 3, 2025 13:28
@weboko weboko requested review from a team and Copilot and removed request for a team June 3, 2025 13:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency version specifiers for multiple libp2p-related packages in various package.json files to enforce concrete versions, preventing inadvertent breakage from minor updates.

  • Hard set concrete versions for libp2p and related packages in tests, sdk, relay, interfaces, enr, discovery, and core packages.
  • Remove caret (^) version specifiers to lock dependency versions.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/tests/package.json Pinned versions for dependencies and devDependencies.
packages/sdk/package.json Updated libp2p package versions to fixed numbers.
packages/relay/package.json Enforced concrete version for libp2p-gossipsub.
packages/interfaces/package.json Pinned version for libp2p-gossipsub in devDependencies.
packages/enr/package.json Hard set libp2p dependency versions in dependencies.
packages/discovery/package.json Fixed version for @libp2p/interface in devDependencies.
packages/core/package.json Pinned libp2p dependency versions in devDependencies.

@weboko weboko changed the title fix: enforce concrete versions on libp2p packages fix: upgrade libp2p packages Jun 9, 2025
@github-actions
Copy link

github-actions bot commented Jun 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 64.78 KB (+2.09% 🔺) 1.3 s (+2.09% 🔺) 5.5 s (-41.96% 🔽) 6.8 s
Waku Simple Light Node 122.53 KB (+4.46% 🔺) 2.5 s (+4.46% 🔺) 10.3 s (-5.53% 🔽) 12.7 s
ECIES encryption 23.04 KB (-0.09% 🔽) 461 ms (-0.09% 🔽) 3.3 s (+11.97% 🔺) 3.8 s
Symmetric encryption 22.51 KB (-0.07% 🔽) 451 ms (-0.07% 🔽) 4.9 s (+42.32% 🔺) 5.4 s
DNS discovery 51.99 KB (+2.33% 🔺) 1.1 s (+2.33% 🔺) 8.1 s (+13.32% 🔺) 9.1 s
Peer Exchange discovery 52.28 KB (+2.08% 🔺) 1.1 s (+2.08% 🔺) 9.1 s (+36.08% 🔺) 10.1 s
Local Peer Cache Discovery 46 KB (+2.98% 🔺) 921 ms (+2.98% 🔺) 6.6 s (-1.84% 🔽) 7.5 s
Privacy preserving protocols 53.39 KB (+2.62% 🔺) 1.1 s (+2.62% 🔺) 7.2 s (-24.95% 🔽) 8.3 s
Waku Filter 55.3 KB (+2.58% 🔺) 1.2 s (+2.58% 🔺) 5.6 s (-23.7% 🔽) 6.7 s
Waku LightPush 52.75 KB (+2.7% 🔺) 1.1 s (+2.7% 🔺) 7.5 s (-12.5% 🔽) 8.6 s
History retrieval protocols 53.15 KB (+2.82% 🔺) 1.1 s (+2.82% 🔺) 6.9 s (-23.1% 🔽) 8 s
Deterministic Message Hashing 18.65 KB (+15.78% 🔺) 373 ms (+15.78% 🔺) 4.2 s (+41.81% 🔺) 4.5 s

@weboko weboko force-pushed the weboko/libp2p-deps branch from d9347aa to caf47c5 Compare June 10, 2025 22:44
@weboko weboko force-pushed the weboko/libp2p-deps branch from caf47c5 to fc7d5da Compare June 19, 2025 20:11
@weboko weboko force-pushed the weboko/libp2p-deps branch from 14fe1f6 to 1d75a4c Compare June 20, 2025 15:32
@weboko weboko changed the title fix: upgrade libp2p packages fix: upgrade libp2p, nodejs and typescript Jun 22, 2025
@weboko
Copy link
Collaborator Author

weboko commented Jun 22, 2025

@waku-org/js-waku I dogfooded these changes and seems no breaking changes affect js-waku functionality based on dogfooding app and e2e tests

pinging to keep you aware that we need to now use:

  • nodejs 22
  • keep an eye on any problems that might occur (low risk tho)

@weboko weboko merged commit fcc6496 into master Jun 22, 2025
22 of 23 checks passed
@weboko weboko deleted the weboko/libp2p-deps branch June 22, 2025 15:41
@weboko weboko mentioned this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: enforce particular dependencies

3 participants