-
Notifications
You must be signed in to change notification settings - Fork 47
fix: upgrade libp2p, nodejs and typescript #2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependency version specifiers for multiple libp2p-related packages in various package.json files to enforce concrete versions, preventing inadvertent breakage from minor updates.
- Hard set concrete versions for libp2p and related packages in tests, sdk, relay, interfaces, enr, discovery, and core packages.
- Remove caret (^) version specifiers to lock dependency versions.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/tests/package.json | Pinned versions for dependencies and devDependencies. |
| packages/sdk/package.json | Updated libp2p package versions to fixed numbers. |
| packages/relay/package.json | Enforced concrete version for libp2p-gossipsub. |
| packages/interfaces/package.json | Pinned version for libp2p-gossipsub in devDependencies. |
| packages/enr/package.json | Hard set libp2p dependency versions in dependencies. |
| packages/discovery/package.json | Fixed version for @libp2p/interface in devDependencies. |
| packages/core/package.json | Pinned libp2p dependency versions in devDependencies. |
size-limit report 📦
|
d9347aa to
caf47c5
Compare
caf47c5 to
fc7d5da
Compare
14fe1f6 to
1d75a4c
Compare
|
@waku-org/js-waku I dogfooded these changes and seems no breaking changes affect js-waku functionality based on dogfooding app and e2e tests pinging to keep you aware that we need to now use:
|
Problem / Description
When
libp2paccidentaly introduced breaking change in minor update it brokejs-waku's consumers.Solution
Hard set
libp2ppackage versions.Notes
Checklist
[ ] Code changes are covered by unit tests.