Skip to content

fix: store peer selection #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weboko wants to merge 3 commits into from
Closed

fix: store peer selection #2414

weboko wants to merge 3 commits into from

Conversation

@weboko
Copy link
Collaborator

@weboko weboko commented Jun 14, 2025

Problem / Description

Solution

Notes

  • Resolves
  • Related to

Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@github-actions
Copy link

github-actions bot commented Jun 14, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 63.54 KB (+0.05% 🔺) 1.3 s (+0.05% 🔺) 1.1 s (-5.59% 🔽) 2.4 s
Waku Simple Light Node 117.3 KB (+0.01% 🔺) 2.4 s (+0.01% 🔺) 1.5 s (-27.66% 🔽) 3.9 s
ECIES encryption 23.06 KB (0%) 462 ms (0%) 728 ms (+28.16% 🔺) 1.2 s
Symmetric encryption 22.52 KB (0%) 451 ms (0%) 814 ms (+2.43% 🔺) 1.3 s
DNS discovery 50.75 KB (0%) 1.1 s (0%) 1.2 s (+29.56% 🔺) 2.2 s
Peer Exchange discovery 51.13 KB (0%) 1.1 s (0%) 1.3 s (+0.15% 🔺) 2.3 s
Local Peer Cache Discovery 44.49 KB (0%) 890 ms (0%) 1.3 s (+55.25% 🔺) 2.2 s
Privacy preserving protocols 52.02 KB (0%) 1.1 s (0%) 1.7 s (-10.04% 🔽) 2.8 s
Waku Filter 54.05 KB (0%) 1.1 s (0%) 1.4 s (-8.16% 🔽) 2.5 s
Waku LightPush 51.37 KB (0%) 1.1 s (0%) 943 ms (-19.78% 🔽) 2 s
History retrieval protocols 51.73 KB (-0.11% 🔽) 1.1 s (-0.11% 🔽) 1.3 s (+115.92% 🔺) 2.3 s
Deterministic Message Hashing 16.03 KB (0%) 321 ms (0%) 368 ms (-41.31% 🔽) 688 ms

weboko
weboko commented Jun 17, 2025
View reviewed changes
packages/sdk/src/store/store.ts

const peer = connectedPeers.find(
(p) => p.id.toString() === this.options?.peer
(p) => p.id.toString() === multiaddr(this.options?.peer).getPeerId()
Copy link
Collaborator Author

@weboko weboko Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be addressed in #2417

weboko
weboko commented Jun 17, 2025
View reviewed changes
packages/sdk/src/filter_next/subscription.ts

const prevPeers = new Set(this.peers);
const peersToAdd = this.peerManager.getPeers();
const peersToAdd = await Promise.all(
Copy link
Collaborator Author

@weboko weboko Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be resolved with #2418

@weboko weboko closed this Jun 17, 2025
@weboko weboko deleted the weboko/fix-store-peer-option branch June 17, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weboko