Skip to content

Conversation

@weboko
Copy link
Collaborator

@weboko weboko commented Jun 19, 2025

Problem / Description

Base protocol needs to be removed as this is small tech debt we have for a while.

Solution

Remove BaseProtocol.

Notes


Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@github-actions
Copy link

github-actions bot commented Jun 19, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 63.46 KB (-0.09% 🔽) 1.3 s (-0.09% 🔽) 1.8 s (-1.14% 🔽) 3.1 s
Waku Simple Light Node 117.3 KB (+0.02% 🔺) 2.4 s (+0.02% 🔺) 2.4 s (+29.14% 🔺) 4.7 s
ECIES encryption 23.06 KB (0%) 462 ms (0%) 871 ms (+9.78% 🔺) 1.4 s
Symmetric encryption 22.52 KB (0%) 451 ms (0%) 613 ms (-9.85% 🔽) 1.1 s
DNS discovery 50.81 KB (+0.12% 🔺) 1.1 s (+0.12% 🔺) 1.4 s (-9.02% 🔽) 2.4 s
Peer Exchange discovery 51.22 KB (+0.18% 🔺) 1.1 s (+0.18% 🔺) 2.2 s (+83.33% 🔺) 3.2 s
Local Peer Cache Discovery 44.67 KB (+0.42% 🔺) 894 ms (+0.42% 🔺) 1.3 s (-17.61% 🔽) 2.2 s
Privacy preserving protocols 52.02 KB (0%) 1.1 s (0%) 1.5 s (-3.68% 🔽) 2.6 s
Waku Filter 53.91 KB (-0.27% 🔽) 1.1 s (-0.27% 🔽) 1.7 s (+33.01% 🔺) 2.8 s
Waku LightPush 51.36 KB (-0.01% 🔽) 1.1 s (-0.01% 🔽) 1.3 s (-40.54% 🔽) 2.3 s
History retrieval protocols 51.7 KB (-0.17% 🔽) 1.1 s (-0.17% 🔽) 1.2 s (-27.58% 🔽) 2.2 s
Deterministic Message Hashing 16.11 KB (+0.46% 🔺) 323 ms (+0.46% 🔺) 721 ms (-0.12% 🔽) 1.1 s

@weboko weboko changed the title feat: connection manager chore!: remove IBaseProtocol Jun 19, 2025
@weboko weboko changed the title chore!: remove IBaseProtocol chore!: remove IBaseProtocol and improve interface on PeerExchange Jun 19, 2025
@weboko weboko marked this pull request as ready for review June 19, 2025 19:56
@weboko weboko requested a review from a team as a code owner June 19, 2025 19:56
@weboko weboko merged commit 7c8d107 into master Jun 20, 2025
17 of 18 checks passed
@weboko weboko deleted the weboko/connection-manager-ref branch June 20, 2025 10:53
@weboko weboko mentioned this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove IBaseProtocol

3 participants