Skip to content

Conversation

@adklempner
Copy link
Member

@adklempner adklempner commented Oct 23, 2025

Problem / Description

As part of release process, we run npm audit to check for vulnerabilities.
The last run resulted in:
19 vulnerabilities (7 low, 3 moderate, 8 high, 1 critical)

Solution

Run npm audit fix and push the updated package-lock.json

Results in:
7 vulnerabilities (6 low, 1 moderate)

Notes

  • Changes to playwright requires running npx playwright install chromium firefox again locally, and bumping the image in CI
  • Related to chore: release master #2706

Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 96.1 KB (0%) 2 s (0%) 821 ms (+1.63% 🔺) 2.8 s
Waku Simple Light Node 147.38 KB (0%) 3 s (0%) 843 ms (+33.66% 🔺) 3.8 s
ECIES encryption 22.51 KB (0%) 451 ms (0%) 452 ms (+77.2% 🔺) 902 ms
Symmetric encryption 21.91 KB (0%) 439 ms (0%) 211 ms (-24.37% 🔽) 649 ms
DNS discovery 52.15 KB (0%) 1.1 s (0%) 360 ms (+15.44% 🔺) 1.5 s
Peer Exchange discovery 52.9 KB (0%) 1.1 s (0%) 510 ms (-13.54% 🔽) 1.6 s
Peer Cache Discovery 46.57 KB (0%) 932 ms (0%) 480 ms (+15.85% 🔺) 1.5 s
Privacy preserving protocols 77.05 KB (0%) 1.6 s (0%) 616 ms (-22.97% 🔽) 2.2 s
Waku Filter 79.69 KB (0%) 1.6 s (0%) 720 ms (+4.09% 🔺) 2.4 s
Waku LightPush 77.77 KB (0%) 1.6 s (0%) 587 ms (-12.78% 🔽) 2.2 s
History retrieval protocols 83.61 KB (0%) 1.7 s (0%) 639 ms (+3.65% 🔺) 2.4 s
Deterministic Message Hashing 28.9 KB (0%) 578 ms (0%) 359 ms (-1.79% 🔽) 937 ms

@adklempner adklempner force-pushed the feat/release-2025-10-24 branch from 610dbaa to 131d775 Compare October 24, 2025 06:48
@adklempner adklempner force-pushed the feat/release-2025-10-24 branch from 131d775 to 4c78b46 Compare October 24, 2025 19:01
@adklempner
Copy link
Member Author

Updating playwright seems like a breaking change, as it now looks for chrome/ff bins in a different folder than before

@adklempner adklempner marked this pull request as ready for review October 24, 2025 23:48
@adklempner adklempner requested a review from a team as a code owner October 24, 2025 23:48
@adklempner adklempner mentioned this pull request Oct 25, 2025
19 tasks
@adklempner adklempner merged commit 0daa81d into master Oct 27, 2025
22 of 23 checks passed
@adklempner adklempner deleted the feat/release-2025-10-24 branch October 27, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants