feat(rln): proof generation and verification with on-chain merkle proof/root #2749
+559
−70
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,101 @@ | ||||||||
| import { expect } from "chai"; | ||||||||
|
|
||||||||
| import { Keystore } from "./keystore/index.js"; | ||||||||
| import { RLNInstance } from "./rln.js"; | ||||||||
| import { BytesUtils } from "./utils/index.js"; | ||||||||
| import { | ||||||||
| calculateRateCommitment, | ||||||||
| extractPathDirectionsFromProof, | ||||||||
| MERKLE_TREE_DEPTH, | ||||||||
| reconstructMerkleRoot | ||||||||
| } from "./utils/merkle.js"; | ||||||||
| import { TEST_KEYSTORE_DATA } from "./utils/test_keystore.js"; | ||||||||
|
|
||||||||
| describe("RLN Proof Integration Tests", function () { | ||||||||
| this.timeout(30000); | ||||||||
|
|
||||||||
| it("validate stored merkle proof data", function () { | ||||||||
| // Convert stored merkle proof strings to bigints | ||||||||
| const merkleProof = TEST_KEYSTORE_DATA.merkleProof.map((p) => BigInt(p)); | ||||||||
|
|
||||||||
| expect(merkleProof).to.be.an("array"); | ||||||||
| expect(merkleProof).to.have.lengthOf(MERKLE_TREE_DEPTH); // RLN uses fixed depth merkle tree | ||||||||
|
|
||||||||
| merkleProof.forEach((element, i) => { | ||||||||
|
Collaborator
There was a problem hiding this comment. nit: |
||||||||
| expect(element).to.be.a( | ||||||||
| "bigint", | ||||||||
| `Proof element ${i} should be a bigint` | ||||||||
| ); | ||||||||
| expect(element).to.not.equal(0n, `Proof element ${i} should not be zero`); | ||||||||
| }); | ||||||||
| }); | ||||||||
|
|
||||||||
| it("should generate a valid RLN proof", async function () { | ||||||||
| const rlnInstance = await RLNInstance.create(); | ||||||||
| // Load credential from test keystore | ||||||||
| const keystore = Keystore.fromString(TEST_KEYSTORE_DATA.keystoreJson); | ||||||||
| if (!keystore) { | ||||||||
| throw new Error("Failed to load test keystore"); | ||||||||
| } | ||||||||
| const credentialHash = TEST_KEYSTORE_DATA.credentialHash; | ||||||||
| const password = TEST_KEYSTORE_DATA.password; | ||||||||
| const credential = await keystore.readCredential(credentialHash, password); | ||||||||
| if (!credential) { | ||||||||
| throw new Error("Failed to unlock credential with provided password"); | ||||||||
| } | ||||||||
|
|
||||||||
| const idCommitment = credential.identity.IDCommitmentBigInt; | ||||||||
|
|
||||||||
| const merkleProof = TEST_KEYSTORE_DATA.merkleProof.map((p) => BigInt(p)); | ||||||||
| const merkleRoot = BigInt(TEST_KEYSTORE_DATA.merkleRoot); | ||||||||
| const membershipIndex = BigInt(TEST_KEYSTORE_DATA.membershipIndex); | ||||||||
| const rateLimit = BigInt(TEST_KEYSTORE_DATA.rateLimit); | ||||||||
|
|
||||||||
| const rateCommitment = calculateRateCommitment(idCommitment, rateLimit); | ||||||||
|
|
||||||||
| const proofElementIndexes = extractPathDirectionsFromProof( | ||||||||
| merkleProof, | ||||||||
| rateCommitment, | ||||||||
| merkleRoot | ||||||||
|
There was a problem hiding this comment. The function call to Consider passing the known index or a reasonable upper bound:
Suggested change
|
||||||||
| ); | ||||||||
| if (!proofElementIndexes) { | ||||||||
| throw new Error("Failed to extract proof element indexes"); | ||||||||
| } | ||||||||
|
|
||||||||
| expect(proofElementIndexes).to.have.lengthOf(MERKLE_TREE_DEPTH); | ||||||||
|
|
||||||||
| const reconstructedRoot = reconstructMerkleRoot( | ||||||||
| merkleProof, | ||||||||
| membershipIndex, | ||||||||
| rateCommitment | ||||||||
| ); | ||||||||
|
|
||||||||
| expect(reconstructedRoot).to.equal( | ||||||||
| merkleRoot, | ||||||||
| "Reconstructed root should match stored root" | ||||||||
| ); | ||||||||
|
|
||||||||
| const testMessage = new TextEncoder().encode("test"); | ||||||||
|
|
||||||||
| const proof = await rlnInstance.zerokit.generateRLNProof( | ||||||||
| testMessage, | ||||||||
| Number(membershipIndex), | ||||||||
| new Date(), | ||||||||
| credential.identity.IDSecretHash, | ||||||||
| merkleProof.map((proof) => BytesUtils.fromBigInt(proof, 32, "little")), | ||||||||
|
There was a problem hiding this comment. Variable name shadowing: the parameter name
Suggested change
|
||||||||
| proofElementIndexes.map((index) => | ||||||||
| BytesUtils.writeUIntLE(new Uint8Array(1), index, 0, 1) | ||||||||
| ), | ||||||||
| Number(rateLimit), | ||||||||
| 0 | ||||||||
| ); | ||||||||
|
|
||||||||
| const isValid = rlnInstance.zerokit.verifyRLNProof( | ||||||||
| BytesUtils.writeUIntLE(new Uint8Array(8), testMessage.length, 0, 8), | ||||||||
| testMessage, | ||||||||
| proof, | ||||||||
| [BytesUtils.fromBigInt(merkleRoot, 32, "little")] | ||||||||
| ); | ||||||||
| expect(isValid).to.be.true; | ||||||||
| }); | ||||||||
| }); | ||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
@waku/interfacespackage was removed from devDependencies, but there's no explanation in the PR description about why this dependency is no longer needed. If it was truly unused, this is good cleanup. However, if there are references to it elsewhere in the codebase, this could cause build failures. Please verify that this removal is intentional and that no code depends on this package.